From: Jakub Jelinek <jakub@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/3] gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831]
Date: Thu, 18 May 2023 14:59:45 +0200 [thread overview]
Message-ID: <ZGYhQXC5I3Fipldh@tucnak> (raw)
In-Reply-To: <20230518125647.2105203-3-jwakely@redhat.com>
On Thu, May 18, 2023 at 01:56:46PM +0100, Jonathan Wakely via Gcc-patches wrote:
> --- a/gcc/testsuite/gcc.test-framework/gen_directive_tests
> +++ b/gcc/testsuite/gcc.test-framework/gen_directive_tests
> @@ -322,8 +322,8 @@ two() {
> echo "${GOOD_PROG}" >> $FILE1
> echo "${GOOD_PROG}" > $FILE2
>
> - if [ "${FAIL_VERSION}" == "yes" ]; then
> - if [ "${EXP}" == "${EXP_PASS}" ]; then
> + if "yes" ]; then
This line looks suspicious...
> + if [ "${EXP}" = "${EXP_PASS}" ]; then
> NAME=${KIND1}-${KIND2}-${EXP_FAIL}
> else
> NAME=${KIND1}-${KIND2}-${EXP_XFAIL}
> @@ -364,8 +364,8 @@ three() {
> echo "${GOOD_PROG}" >> $FILE1
> echo "${GOOD_PROG}" > $FILE2
>
> - if [ "${FAIL_VERSION}" == "${yes}" ]; then
> - if [ "${EXP}" == "${EXP_PASS}" ]; then
> + if [ "${FAIL_VERSION}" = "${yes}" ]; then
> + if [ "${EXP}" = "${EXP_PASS}" ]; then
> NAME=${KIND1}-${KIND2}-${KIND3}-${EXP_FAIL}
> else
> NAME=${KIND1}-${KIND2}-${KIND3}-${EXP_XFAIL}
> --
> 2.40.1
Jakub
next prev parent reply other threads:[~2023-05-18 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 12:56 [PATCH 0/3] Fix nonportable shell syntax in "test" and "[" commands Jonathan Wakely
2023-05-18 12:56 ` [PATCH 1/3] gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831] Jonathan Wakely
2023-05-18 13:00 ` Jakub Jelinek
2023-05-18 14:47 ` Bernhard Reutner-Fischer
2023-05-18 15:13 ` Jonathan Wakely
2023-05-18 12:56 ` [PATCH 2/3] " Jonathan Wakely
2023-05-18 12:59 ` Jakub Jelinek [this message]
2023-05-18 13:05 ` Jonathan Wakely
2023-05-18 13:03 ` [PATCH v2 " Jonathan Wakely
2023-05-18 13:15 ` Jakub Jelinek
2023-05-18 12:56 ` [PATCH 3/3] contrib: " Jonathan Wakely
2023-05-18 13:00 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGYhQXC5I3Fipldh@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).