public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [pushed] Darwin: Correct a version check.
@ 2024-04-02 11:26 Iain Sandoe
  0 siblings, 0 replies; only message in thread
From: Iain Sandoe @ 2024-04-02 11:26 UTC (permalink / raw)
  To: gcc-patches

Tested on x86_64-darwin17,21,23, pushed to trunk, thanks,
Iain

--- 8< ---

When the version for dsymutil comes from a clang build, it is
of the form NNmm.pp.qq where NN and mm are the major and minor
LLVM version components.  We need to check for a major version
greater than or equal to 7 - so use 700 in the check.

gcc/ChangeLog:

	* config/darwin.cc (darwin_override_options): Update the
	clang major version value in the dsymutil check.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
---
 gcc/config/darwin.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/darwin.cc b/gcc/config/darwin.cc
index c37a1a4756f..63b8c509405 100644
--- a/gcc/config/darwin.cc
+++ b/gcc/config/darwin.cc
@@ -3420,7 +3420,7 @@ darwin_override_options (void)
       /* External toolchains based on LLVM or clang 7+ have support for
 	 dwarf-4.  */
       if ((dsymutil_version.kind == LLVM && dsymutil_version.major >= 7)
-	  || (dsymutil_version.kind == CLANG && dsymutil_version.major >= 7))
+	  || (dsymutil_version.kind == CLANG && dsymutil_version.major >= 700))
 	dwarf_version = 4;
       else if (dsymutil_version.kind == DWARFUTILS
 	       && dsymutil_version.major >= 121)
-- 
2.39.2 (Apple Git-143)


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-02 11:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-02 11:26 [pushed] Darwin: Correct a version check Iain Sandoe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).