From: Jeff Law <jeffreyalaw@gmail.com>
To: Xin Liu <xin.liu@oss.cipunited.com>, gcc-patches@gcc.gnu.org
Cc: Matthew Fortune <matthew.fortune@imgtec.com>
Subject: Re: [PATCH] Testsuite: Disable micromips for MSA tests
Date: Sat, 11 Mar 2023 08:42:13 -0700 [thread overview]
Message-ID: <444a2cf7-c3a9-255e-63eb-12ccd8f06df0@gmail.com> (raw)
In-Reply-To: <20230221023857.211542-1-xin.liu@oss.cipunited.com>
On 2/20/23 19:39, Xin Liu wrote:
> From: Matthew Fortune <matthew.fortune@imgtec.com>
>
> ---
> gcc/testsuite/gcc.target/mips/mips.exp | 1 +
> 1 file changed, 1 insertion(+)
Unfortunately, you haven't given anyone any background that would allow
them to evaluate/review this patch.
I'm guessing that MSA does not support micromips, is that correct?
And for the future, please include a ChangeLog entry with patches. A
ChangeLog entry describes what changed, not why something changes. A
reasonable ChangeLog for this patch might be:
gcc/testsuite:
* gcc.target/mips/mips.exp (mips-dg-options): Disable micromips
for MSA tests.
Jeff
next prev parent reply other threads:[~2023-03-11 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 2:39 Xin Liu
2023-03-11 15:42 ` Jeff Law [this message]
2023-03-14 5:46 ` Xin Liu
2023-03-19 17:31 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444a2cf7-c3a9-255e-63eb-12ccd8f06df0@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=matthew.fortune@imgtec.com \
--cc=xin.liu@oss.cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).