Re: [PATCH] Testsuite: Disable micromips for MSA tests

["Xin Liu" <xin.liu@oss.cipunited.com>]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

Thanks for your feedback. You're right that MicroMIPS doesn't support 
MSA, so disabling micromips for MSA tests is a reasonable change.
I'll make sure to include a ChangeLog entry with a clear description of 
future patches. Thanks for the suggestions, and I'll strive to improve 
my work based on your feedback.

On 2023/3/11 23:42, Jeff Law wrote:
>
>
> On 2/20/23 19:39, Xin Liu wrote:
>> From: Matthew Fortune <matthew.fortune@imgtec.com>
>>
>> ---
>>   gcc/testsuite/gcc.target/mips/mips.exp | 1 +
>>   1 file changed, 1 insertion(+)
> Unfortunately, you haven't given anyone any background that would 
> allow them to evaluate/review this patch.
>
> I'm guessing that MSA does not support micromips, is that correct?
>
> And for the future, please include a ChangeLog entry with patches.  A 
> ChangeLog entry describes what changed, not why something changes.  A 
> reasonable ChangeLog for this patch might be:
>
> gcc/testsuite:
>     * gcc.target/mips/mips.exp (mips-dg-options): Disable micromips
>     for MSA tests.
>
> Jeff