[PATCH] Testsuite: mark IPA test as requiring alias support

[PATCH] Testsuite: mark IPA test as requiring alias support

[FX Coudert]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

Hi,

The fact that this test needs alias support was indicated in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85656 but never committed. Without it, the test fails on darwin.

OK to commit?

FX


[-- Attachment #2: 0001-Testsuite-mark-IPA-test-as-requiring-alias-support.patch --]
[-- Type: application/octet-stream, Size: 1035 bytes --]

From a9f67235ee5f7e08cd13dfebaa4715b19df911ca Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gmail.com>
Date: Sun, 20 Aug 2023 14:13:22 +0200
Subject: [PATCH] Testsuite: mark IPA test as requiring alias support

This was indicated in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85656
but never committed. Without it, the test fails on darwin.

gcc/testsuite/ChangeLog:
	* gcc.dg/ipa/ipa-icf-38.c: Require alias support.
---
 gcc/testsuite/gcc.dg/ipa/ipa-icf-38.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-icf-38.c b/gcc/testsuite/gcc.dg/ipa/ipa-icf-38.c
index 452e1b88514..57c5262dd4a 100644
--- a/gcc/testsuite/gcc.dg/ipa/ipa-icf-38.c
+++ b/gcc/testsuite/gcc.dg/ipa/ipa-icf-38.c
@@ -1,4 +1,5 @@
 /* { dg-do link } */
+/* { dg-require-alias "" } */
 /* { dg-options "-O2 -fdump-ipa-icf-optimized -flto -fdump-tree-optimized" } */
 /* { dg-require-effective-target lto } */
 /* { dg-additional-sources "ipa-icf-38a.c" }*/
-- 
2.39.2 (Apple Git-143)

Re: [PATCH] Testsuite: mark IPA test as requiring alias support

[Iain Sandoe]

Hi FX,

> On 20 Aug 2023, at 13:15, FX Coudert via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:

> The fact that this test needs alias support was indicated in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85656 but never committed. Without it, the test fails on darwin.
> 
> OK to commit?

IMO, changes like this qualify as obvious, so I’d go ahead (thanks for this test fail triage)

Iain

> 
> FX
> 
> <0001-Testsuite-mark-IPA-test-as-requiring-alias-support.patch>

Re: [PATCH] Testsuite: mark IPA test as requiring alias support

[FX Coudert]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

Hi,

> IMO, changes like this qualify as obvious, so I’d go ahead (thanks for this test fail triage)

Makes sense. I’ve committed, as well as another one, attached, slightly amending the expected pattern of a sarif plugin test.

FX


[-- Attachment #2: 0001-Testsuite-plugin-make-testcase-pattern-more-flexible.patch --]
[-- Type: application/octet-stream, Size: 1525 bytes --]

From 7be59c50478462a4bba81cddb5d2af038d4c1b1a Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gmail.com>
Date: Sun, 20 Aug 2023 19:35:18 +0200
Subject: [PATCH] Testsuite, plugin: make testcase pattern more flexible

On Darwin, the message recorded in the sarif file contains:
  "message": {"text": "Segmentation fault: 11"}
which is different from, e.g., linux:
  "message": {"text": "Segmentation fault"}

Adjusting the testcase pattern to be a little more flexible.

gcc/testsuite/ChangeLog:
	* gcc.dg/plugin/crash-test-write-though-null-sarif.c: Update
	expected pattern.
---
 .../gcc.dg/plugin/crash-test-write-though-null-sarif.c          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/plugin/crash-test-write-though-null-sarif.c b/gcc/testsuite/gcc.dg/plugin/crash-test-write-though-null-sarif.c
index 83b38d2ffb5..513d66c528d 100644
--- a/gcc/testsuite/gcc.dg/plugin/crash-test-write-though-null-sarif.c
+++ b/gcc/testsuite/gcc.dg/plugin/crash-test-write-though-null-sarif.c
@@ -61,4 +61,4 @@ void test_inject_write_through_null (void)
                { dg-final { scan-sarif-file "\"startColumn\": 3" } }
                { dg-final { scan-sarif-file "\"endColumn\": 31" } }
          { dg-final { scan-sarif-file "\"message\": " } }
-           { dg-final { scan-sarif-file "\"text\": \"Segmentation fault\"" } } */
+           { dg-final { scan-sarif-file "\"text\": \"Segmentation fault" } } */
-- 
2.39.2 (Apple Git-143)