From: Sandra Loosemore <sandra.loosemore@siemens.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: Sandra Loosemore <sandra@codesourcery.com>,
gcc-patches@gcc.gnu.org, Gerald Pfeifer <gerald@pfeifer.com>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v2 1/5] docs: Create Indices appendix
Date: Sat, 11 Mar 2023 12:34:48 -0700 [thread overview]
Message-ID: <524da6ec-f5b5-c41d-a96f-2481ffe3c5d6@siemens.com> (raw)
In-Reply-To: <86356b1nnh.fsf@aarsen.me>
On 3/11/23 05:22, Arsen Arsenović wrote:
>
> OK, changed up a bit, what do you think of this:
>
> maintainer-scripts/ChangeLog:
>
> * update_web_docs_git: Set CONTENTS_OUTPUT_LOCATION=inline in
> order to put @shortcontents above contents. See
> 9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com on
> gcc-patches.
>
> gcc/ChangeLog:
>
> * configure.ac: Add check for the Texinfo 6.8
> CONTENTS_OUTPUT_LOCATION customization variable and set it if
> supported.
> * configure: Regenerate.
> * Makefile.in (MAKEINFO_TOC_INLINE_FLAG): New variable. Set by
> configure.ac to -c CONTENTS_OUTPUT_LOCATION=inline if
> CONTENTS_OUTPUT_LOCATION support is detected, empty otherwise.
> ($(build_htmldir)/%/index.html): Pass MAKEINFO_TOC_INLINE_FLAG.
> See 9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com on
> gcc-patches.
Hmmm, first off, I think somebody other than me needs to approve the
configure and makefile pieces, as well as the maintainer-scripts part.
It looks conceptually right to me, although I would add a comment to new
configure.ac piece like
"Newer versions of Texinfo put the table of contents in the wrong place
by default in HTML output, but provide a command-line option to restore
the desired behavior. Check whether we need to do that."
I don't know whether the maintainer-scripts change needs to be made
conditional too. :-S
BTW, this change probably needs to be backported to all active GCC
branches (10, 11, and 12) too after it's committed to mainline.
-Sandra
next prev parent reply other threads:[~2023-03-11 19:35 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 10:27 [PATCH v2 0/5] A small Texinfo refinement Arsen Arsenović
2023-02-23 10:27 ` [PATCH v2 1/5] docs: Create Indices appendix Arsen Arsenović
2023-03-09 3:16 ` Sandra Loosemore
2023-03-09 10:12 ` Arsen Arsenović
2023-03-09 20:38 ` Arsen Arsenović
2023-03-11 1:12 ` Sandra Loosemore
2023-03-11 1:34 ` Arsen Arsenović
2023-03-11 12:22 ` Arsen Arsenović
2023-03-11 19:22 ` Gerald Pfeifer
2023-03-11 20:22 ` Arsen Arsenović
2023-03-11 19:34 ` Sandra Loosemore [this message]
2023-03-11 20:14 ` Arsen Arsenović
2023-03-11 20:32 ` [PATCH v2] html: Set CONTENTS_OUTPUT_LOCATION=inline if makeinfo supports it Arsen Arsenović
2023-03-12 10:25 ` [PATCH v2 1/5] docs: Create Indices appendix Gerald Pfeifer
2023-03-12 12:23 ` Arsen Arsenović
2023-02-23 10:27 ` [PATCH v2 2/5] **/*.texi: Reorder index entries Arsen Arsenović
2023-02-23 23:50 ` Gerald Pfeifer
2023-02-23 10:27 ` [PATCH v2 3/5] doc: Add @defbuiltin family of helpers, set documentlanguage Arsen Arsenović
2023-03-09 23:50 ` Sandra Loosemore
2023-02-23 10:27 ` [PATCH v2 4/5] Update texinfo.tex, remove the @gol macro/alias Arsen Arsenović
2023-03-09 23:55 ` Sandra Loosemore
2023-03-10 0:17 ` Gerald Pfeifer
2023-03-10 10:33 ` Thomas Schwinge
2023-03-10 12:49 ` Arsen Arsenović
2023-03-10 15:51 ` Gerald Pfeifer
2023-03-10 15:58 ` Arsen Arsenović
2023-03-10 12:48 ` Arsen Arsenović
2023-03-10 15:49 ` Arsen Arsenović
2023-03-18 20:14 ` Ping (gcc/configure.ac, docs): " Arsen Arsenović
2023-03-20 22:01 ` Sandra Loosemore
2023-03-20 23:06 ` Joseph Myers
2023-03-20 23:27 ` Arsen Arsenović
2023-03-20 23:35 ` Arsen Arsenović
2023-03-21 9:52 ` Arsen Arsenović
2023-03-21 23:11 ` Gerald Pfeifer
2023-02-23 10:27 ` [PATCH v2 5/5] update_web_docs_git: Update CSS reference to new manual CSS Arsen Arsenović
2023-03-10 0:07 ` Sandra Loosemore
2023-03-10 13:00 ` Arsen Arsenović
2023-02-25 22:04 ` [PATCH v2 0/5] A small Texinfo refinement Thomas Schwinge
2023-02-26 14:54 ` Arsen Arsenović
2023-03-08 1:56 ` Sandra Loosemore
2023-03-08 9:11 ` Arsen Arsenović
2023-03-08 18:38 ` Sandra Loosemore
2023-03-08 21:22 ` Arsen Arsenović
2023-03-09 1:09 ` Sandra Loosemore
2023-03-09 1:19 ` Andrew Pinski
2023-03-09 8:26 ` Richard Biener
2023-03-09 23:35 ` Sandra Loosemore
2023-03-10 8:50 ` Iain Sandoe
2023-03-10 17:51 ` Sandra Loosemore
2023-03-10 18:09 ` Sandra Loosemore
2023-03-10 19:00 ` Gerald Pfeifer
2023-03-13 9:05 ` Richard Biener
2023-03-13 11:01 ` Arsen Arsenović
2023-05-29 15:06 ` NightStrike
2023-05-29 17:26 ` Arsen Arsenović
2023-05-29 19:27 ` Sandra Loosemore
2023-03-09 10:22 ` Arsen Arsenović
2023-03-09 8:28 ` Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524da6ec-f5b5-c41d-a96f-2481ffe3c5d6@siemens.com \
--to=sandra.loosemore@siemens.com \
--cc=arsen@aarsen.me \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=joseph@codesourcery.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).