public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Christophe Lyon <christophe.lyon@linaro.org>,
	gcc-patches@gcc.gnu.org, Kyrylo.Tkachov@arm.com
Subject: Re: [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp
Date: Wed, 28 Jun 2023 11:20:05 +0100	[thread overview]
Message-ID: <53fc10c5-8827-fb59-3cc6-4f48c904f846@arm.com> (raw)
In-Reply-To: <20230628092631.3173114-1-christophe.lyon@linaro.org>

On 28/06/2023 10:26, Christophe Lyon via Gcc-patches wrote:
> If GCC is configured with the default (soft) -mfloat-abi, and we don't
> override the target_board test flags appropriately,
> gcc.target/arm/mve/general-c/nomve_fp_1.c fails for lack of
> -mfloat-abi=softfp or -mfloat-abi=hard, because it doesn't use
> dg-add-options arm_v8_1m_mve (on purpose, see comment in the test).
> 
> Require and use the options needed for arm_fp to fix this problem.
> 
> 2023-06-28  Christophe Lyon  <christophe.lyon@linaro.org>
> 
> 	gcc/testsuite/
> 	* gcc.target/arm/mve/general-c/nomve_fp_1.c: Require arm_fp.
> ---
>   gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c b/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c
> index 21c2af16a61..c9d279ead68 100644
> --- a/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c
> +++ b/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c
> @@ -1,9 +1,11 @@
>   /* { dg-do compile } */
>   /* { dg-require-effective-target arm_v8_1m_mve_ok } */
> +/* { dg-require-effective-target arm_fp_ok } */
>   /* Do not use dg-add-options arm_v8_1m_mve, because this might expand to "",
>      which could imply mve+fp depending on the user settings. We want to make
>      sure the '+fp' extension is not enabled.  */
>   /* { dg-options "-mfpu=auto -march=armv8.1-m.main+mve" } */
> +/* { dg-add-options arm_fp } */
>   
>   #include <arm_mve.h>
>   

OK.

  parent reply	other threads:[~2023-06-28 10:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28  9:26 Christophe Lyon
2023-06-28  9:26 ` [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or double precision FPU Christophe Lyon
2023-06-28 10:20   ` [PATCH 2/2] [testsuite, arm]: " Richard Earnshaw (lists)
2023-06-28 10:20 ` Richard Earnshaw (lists) [this message]
2023-07-13 10:21 [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp Christophe Lyon
2023-07-14 15:43 ` Kyrylo Tkachov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53fc10c5-8827-fb59-3cc6-4f48c904f846@arm.com \
    --to=richard.earnshaw@arm.com \
    --cc=Kyrylo.Tkachov@arm.com \
    --cc=christophe.lyon@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).