Re: Regression with "recomputation and PR 109154"

[Jeff Law <jeffreyalaw@gmail.com>]

On 3/31/23 10:12, Hans-Peter Nilsson via Gcc-patches wrote:
>> Attached. I also removed the bogus warning in Walloc-13.c that no longer
>> happens
> 
>>      Add recursive GORI recompuations with a depth limit.
>>      
>>              PR tree-optimization/109154
>>              gcc/
>>              * gimple-range-gori.cc (gori_compute::may_recompute_p): Add depth limit.
>>              * gimple-range-gori.h (may_recompute_p): Add depth param.
>>              * params.opt (ranger-recompute-depth): New param.
>>      
>>              gcc/testsuite/
>>              * gcc.dg/Walloca-13.c: Remove bogus warning that is now fixed.
> 
> This patch, commit r13-6945-g429a7a88438cc8, caused a
> test-suite regression; FAIL for 'gcc.dg/tree-ssa/pr23109.c
> scan-tree-dump-not recip "reciptmp"' for cris-elf that I
> logged at PR109363.
> 
> Perhaps it's somewhat of a similar nature as Walloca-13.c
> but then again it's not an bogus warning that's gone.
> 
> Is it expected and I should just blankly xfail it or is it
> worth more attention?  I'm a bit surprised that it hasn't
> shown up for other targets though.
I already let Andrew know -- it's affecting a ton of targets.  It may be 
the case that we just need to adjust the param for that test.

jeff