From: Jakub Jelinek <jakub@redhat.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: Jeff Law <jeffreyalaw@gmail.com>,
Hans-Peter Nilsson <hp@axis.com>,
gcc-patches@gcc.gnu.org, richard.guenther@gmail.com,
aldyh@redhat.com
Subject: Re: Regression with "recomputation and PR 109154"
Date: Fri, 31 Mar 2023 19:37:21 +0200 [thread overview]
Message-ID: <ZCcaUc9G0mtqFpBd@tucnak> (raw)
In-Reply-To: <fe66bb85-62b2-ae8f-ff44-57cecc48af4a@redhat.com>
On Fri, Mar 31, 2023 at 01:02:18PM -0400, Andrew MacLeod wrote:
> I guess it figures the recip is safe to put in, there will not be a divide
> by zero.
I think the problem was that 1/d was hoisted before the loop; as long as
it is guarded with the d > 0.01 or e > 0.005 condition, it is fine.
The test probably should have been a runtime test, doing the main stuff
in some other noipa function and doing fetestexcept after it or something
similar.
> I guess the test is no longer testing what it should be?
>
> And yes, we could set he param back to 1 for the test...
> add --param=ranger-recompute-depth=1 makes the "issue" go away :-) for
> now.
That looks reasonable unless we rewrite the test into runtime one (but we'd
then need to double check that it was really miscompiled and would fail back
then in 4.0).
Jakub
next prev parent reply other threads:[~2023-03-31 17:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 17:22 recomputation and PR 109154 Andrew MacLeod
2023-03-30 6:42 ` Richard Biener
2023-03-30 13:41 ` Jakub Jelinek
2023-03-30 15:58 ` Andrew MacLeod
2023-03-30 16:05 ` Jakub Jelinek
2023-03-30 20:39 ` Andrew MacLeod
2023-03-31 6:08 ` Andrew Pinski
2023-03-31 16:12 ` Regression with "recomputation and PR 109154" Hans-Peter Nilsson
2023-03-31 16:20 ` Jeff Law
2023-03-31 17:02 ` Andrew MacLeod
2023-03-31 17:37 ` Jakub Jelinek [this message]
2023-03-31 19:48 ` Andrew MacLeod
2023-03-31 19:59 ` Jeff Law
2023-03-31 20:16 ` Andrew MacLeod
2023-03-31 20:20 ` Jeff Law
2023-03-31 23:31 ` Hans-Peter Nilsson
2023-04-01 1:11 ` Andrew MacLeod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCcaUc9G0mtqFpBd@tucnak \
--to=jakub@redhat.com \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@axis.com \
--cc=jeffreyalaw@gmail.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).