From: "Martin Liška" <mliska@suse.cz>
To: gcc-patches@gcc.gnu.org
Cc: Jan Hubicka <hubicka@ucw.cz>, Martin Jambor <mjambor@suse.cz>
Subject: Re: [PATCH] ipa: silent -Wodr notes with -w
Date: Tue, 24 Jan 2023 14:34:44 +0100 [thread overview]
Message-ID: <6824de85-b34f-6b0c-c300-3a5beba682a4@suse.cz> (raw)
In-Reply-To: <83376324-e80c-8811-9c6f-a3df8b74f92b@suse.cz>
PING^4
On 1/13/23 10:09, Martin Liška wrote:
> PING^3
>
> On 12/22/22 13:15, Martin Liška wrote:
>> PING^2
>>
>> On 12/9/22 09:27, Martin Liška wrote:
>>> PING^1
>>>
>>> On 12/2/22 12:27, Martin Liška wrote:
>>>> If -w is used, warn_odr properly sets *warned = false and
>>>> so it should be preserved when calling warn_types_mismatch.
>>>>
>>>> Noticed that during a LTO reduction where I used -w.
>>>>
>>>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>>>
>>>> Ready to be installed?
>>>> Thanks,
>>>> Martin
>>>>
>>>> gcc/ChangeLog:
>>>>
>>>> * ipa-devirt.cc (odr_types_equivalent_p): Respect *warned
>>>> value if set.
>>>> ---
>>>> gcc/ipa-devirt.cc | 12 ++++++------
>>>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/gcc/ipa-devirt.cc b/gcc/ipa-devirt.cc
>>>> index 265d07bb354..bcdc50c5bd7 100644
>>>> --- a/gcc/ipa-devirt.cc
>>>> +++ b/gcc/ipa-devirt.cc
>>>> @@ -1300,7 +1300,7 @@ odr_types_equivalent_p (tree t1, tree t2, bool warn, bool *warned,
>>>> warn_odr (t1, t2, NULL, NULL, warn, warned,
>>>> G_("it is defined as a pointer to different type "
>>>> "in another translation unit"));
>>>> - if (warn && warned)
>>>> + if (warn && (warned == NULL || *warned))
>>>> warn_types_mismatch (TREE_TYPE (t1), TREE_TYPE (t2),
>>>> loc1, loc2);
>>>> return false;
>>>> @@ -1315,7 +1315,7 @@ odr_types_equivalent_p (tree t1, tree t2, bool warn, bool *warned,
>>>> warn_odr (t1, t2, NULL, NULL, warn, warned,
>>>> G_("a different type is defined "
>>>> "in another translation unit"));
>>>> - if (warn && warned)
>>>> + if (warn && (warned == NULL || *warned))
>>>> warn_types_mismatch (TREE_TYPE (t1), TREE_TYPE (t2), loc1, loc2);
>>>> return false;
>>>> }
>>>> @@ -1333,7 +1333,7 @@ odr_types_equivalent_p (tree t1, tree t2, bool warn, bool *warned,
>>>> warn_odr (t1, t2, NULL, NULL, warn, warned,
>>>> G_("a different type is defined in another "
>>>> "translation unit"));
>>>> - if (warn && warned)
>>>> + if (warn && (warned == NULL || *warned))
>>>> warn_types_mismatch (TREE_TYPE (t1), TREE_TYPE (t2), loc1, loc2);
>>>> }
>>>> gcc_assert (TYPE_STRING_FLAG (t1) == TYPE_STRING_FLAG (t2));
>>>> @@ -1375,7 +1375,7 @@ odr_types_equivalent_p (tree t1, tree t2, bool warn, bool *warned,
>>>> warn_odr (t1, t2, NULL, NULL, warn, warned,
>>>> G_("has different return value "
>>>> "in another translation unit"));
>>>> - if (warn && warned)
>>>> + if (warn && (warned == NULL || *warned))
>>>> warn_types_mismatch (TREE_TYPE (t1), TREE_TYPE (t2), loc1, loc2);
>>>> return false;
>>>> }
>>>> @@ -1398,7 +1398,7 @@ odr_types_equivalent_p (tree t1, tree t2, bool warn, bool *warned,
>>>> warn_odr (t1, t2, NULL, NULL, warn, warned,
>>>> G_("has different parameters in another "
>>>> "translation unit"));
>>>> - if (warn && warned)
>>>> + if (warn && (warned == NULL || *warned))
>>>> warn_types_mismatch (TREE_VALUE (parms1),
>>>> TREE_VALUE (parms2), loc1, loc2);
>>>> return false;
>>>> @@ -1484,7 +1484,7 @@ odr_types_equivalent_p (tree t1, tree t2, bool warn, bool *warned,
>>>> warn_odr (t1, t2, f1, f2, warn, warned,
>>>> G_("a field of same name but different type "
>>>> "is defined in another translation unit"));
>>>> - if (warn && warned)
>>>> + if (warn && (warned == NULL || *warned))
>>>> warn_types_mismatch (TREE_TYPE (f1), TREE_TYPE (f2), loc1, loc2);
>>>> return false;
>>>> }
>>>
>>
>
next prev parent reply other threads:[~2023-01-24 13:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 11:27 Martin Liška
2022-12-09 8:27 ` Martin Liška
2022-12-22 12:15 ` Martin Liška
2023-01-13 9:09 ` Martin Liška
2023-01-24 13:34 ` Martin Liška [this message]
2023-02-01 13:13 ` Martin Liška
2023-02-01 14:26 ` Martin Jambor
2023-02-01 14:44 ` Martin Liška
2023-02-07 0:35 ` Jan Hubicka
2023-02-09 0:10 ` Jan Hubicka
2023-02-09 7:44 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6824de85-b34f-6b0c-c300-3a5beba682a4@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).