public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Martin Jambor <mjambor@suse.cz>
To: "Martin Liška" <mliska@suse.cz>, gcc-patches@gcc.gnu.org
Cc: Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] ipa: silent -Wodr notes with -w
Date: Wed, 01 Feb 2023 15:26:45 +0100	[thread overview]
Message-ID: <ri6cz6tbgwq.fsf@suse.cz> (raw)
In-Reply-To: <c210778d-e7d8-5d00-7255-329f7dfec052@suse.cz>

Hi,

On Fri, Dec 02 2022, Martin Liška wrote:
> If -w is used, warn_odr properly sets *warned = false and
> so it should be preserved when calling warn_types_mismatch.
>
> Noticed that during a LTO reduction where I used -w.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> 	* ipa-devirt.cc (odr_types_equivalent_p): Respect *warned
> 	value if set.

Sorry for skipping this for so long, usually ODR stuff is... interesting
to the point I gladly leave it to Honza.

Please go ahead and commit the patch.  The way I read the code, your
version must have been the intended behavior and the dereference is
missing.

Thanks,

Martin


  parent reply	other threads:[~2023-02-01 14:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 11:27 Martin Liška
2022-12-09  8:27 ` Martin Liška
2022-12-22 12:15   ` Martin Liška
2023-01-13  9:09     ` Martin Liška
2023-01-24 13:34       ` Martin Liška
2023-02-01 13:13         ` Martin Liška
2023-02-01 14:26 ` Martin Jambor [this message]
2023-02-01 14:44   ` Martin Liška
2023-02-07  0:35     ` Jan Hubicka
2023-02-09  0:10       ` Jan Hubicka
2023-02-09  7:44         ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ri6cz6tbgwq.fsf@suse.cz \
    --to=mjambor@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).