public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: Martin Jambor <mjambor@suse.cz>, gcc-patches@gcc.gnu.org
Cc: Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] ipa: silent -Wodr notes with -w
Date: Wed, 1 Feb 2023 15:44:21 +0100	[thread overview]
Message-ID: <160b53bd-0747-9699-2fef-62415bb6450f@suse.cz> (raw)
In-Reply-To: <ri6cz6tbgwq.fsf@suse.cz>

On 2/1/23 15:26, Martin Jambor wrote:
> Hi,
> 
> On Fri, Dec 02 2022, Martin Liška wrote:
>> If -w is used, warn_odr properly sets *warned = false and
>> so it should be preserved when calling warn_types_mismatch.
>>
>> Noticed that during a LTO reduction where I used -w.
>>
>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>
>> Ready to be installed?
>> Thanks,
>> Martin
>>
>> gcc/ChangeLog:
>>
>> 	* ipa-devirt.cc (odr_types_equivalent_p): Respect *warned
>> 	value if set.
> 

Hi.

> Sorry for skipping this for so long, usually ODR stuff is... interesting
> to the point I gladly leave it to Honza.

Makes sense, however, he's not much active when it comes to patch review.

> 
> Please go ahead and commit the patch.  The way I read the code, your
> version must have been the intended behavior and the dereference is
> missing.

Yep, the patch seems to me quite straightforward.

Thanks,
Martin

> 
> Thanks,
> 
> Martin
> 


  reply	other threads:[~2023-02-01 14:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 11:27 Martin Liška
2022-12-09  8:27 ` Martin Liška
2022-12-22 12:15   ` Martin Liška
2023-01-13  9:09     ` Martin Liška
2023-01-24 13:34       ` Martin Liška
2023-02-01 13:13         ` Martin Liška
2023-02-01 14:26 ` Martin Jambor
2023-02-01 14:44   ` Martin Liška [this message]
2023-02-07  0:35     ` Jan Hubicka
2023-02-09  0:10       ` Jan Hubicka
2023-02-09  7:44         ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160b53bd-0747-9699-2fef-62415bb6450f@suse.cz \
    --to=mliska@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=mjambor@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).