* [PATCH] tree.def: Remove outdated comment on SAD_EXPR
@ 2023-02-08 9:16 Jakub Jelinek
2023-02-08 10:54 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2023-02-08 9:16 UTC (permalink / raw)
To: Richard Sandiford, Richard Biener; +Cc: gcc-patches
Hi!
While looking at PR108692, I've noticed SAD_EXPR comment mentions that
WIDEN_MINUS_EXPR is missing, which is not true anymore since r11-5160.
The following patch just removes that part of the comment.
Ok for trunk?
2023-02-08 Jakub Jelinek <jakub@redhat.com>
* tree.def (SAD_EXPR): Remove outdated comment about missing
WIDEN_MINUS_EXPR.
--- gcc/tree.def.jj 2023-01-02 09:32:28.118202450 +0100
+++ gcc/tree.def 2023-02-08 10:05:52.795587292 +0100
@@ -1341,8 +1341,7 @@ DEFTREECODE (WIDEN_SUM_EXPR, "widen_sum_
The first two arguments are of type t1 which should be integer.
The third argument and the result are of type t2, such that t2 is at least
twice the size of t1. Like DOT_PROD_EXPR, SAD_EXPR (arg1,arg2,arg3) is
- equivalent to (note we don't have WIDEN_MINUS_EXPR now, but we assume its
- behavior is similar to WIDEN_SUM_EXPR):
+ equivalent to:
tmp = WIDEN_MINUS_EXPR (arg1, arg2)
tmp2 = ABS_EXPR (tmp)
arg3 = PLUS_EXPR (tmp2, arg3)
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tree.def: Remove outdated comment on SAD_EXPR
2023-02-08 9:16 [PATCH] tree.def: Remove outdated comment on SAD_EXPR Jakub Jelinek
@ 2023-02-08 10:54 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2023-02-08 10:54 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Richard Sandiford, gcc-patches
> Am 08.02.2023 um 10:17 schrieb Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org>:
>
> Hi!
>
> While looking at PR108692, I've noticed SAD_EXPR comment mentions that
> WIDEN_MINUS_EXPR is missing, which is not true anymore since r11-5160.
>
> The following patch just removes that part of the comment.
>
> Ok for trunk?
Ok
Richard
>
> 2023-02-08 Jakub Jelinek <jakub@redhat.com>
>
> * tree.def (SAD_EXPR): Remove outdated comment about missing
> WIDEN_MINUS_EXPR.
>
> --- gcc/tree.def.jj 2023-01-02 09:32:28.118202450 +0100
> +++ gcc/tree.def 2023-02-08 10:05:52.795587292 +0100
> @@ -1341,8 +1341,7 @@ DEFTREECODE (WIDEN_SUM_EXPR, "widen_sum_
> The first two arguments are of type t1 which should be integer.
> The third argument and the result are of type t2, such that t2 is at least
> twice the size of t1. Like DOT_PROD_EXPR, SAD_EXPR (arg1,arg2,arg3) is
> - equivalent to (note we don't have WIDEN_MINUS_EXPR now, but we assume its
> - behavior is similar to WIDEN_SUM_EXPR):
> + equivalent to:
> tmp = WIDEN_MINUS_EXPR (arg1, arg2)
> tmp2 = ABS_EXPR (tmp)
> arg3 = PLUS_EXPR (tmp2, arg3)
>
> Jakub
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-08 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 9:16 [PATCH] tree.def: Remove outdated comment on SAD_EXPR Jakub Jelinek
2023-02-08 10:54 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).