OpenMP Patch Ping

OpenMP Patch Ping

[Tobias Burnus]

Hi all, hello Jakub,

Below is the updated list to last ping,
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607178.html

NOTE to the list below: I have stopped checking older patches. I know
some more are pending review, others need to be revised. I will re-check,
once the below listed patches have been reviewed. Cf. old list.

Thanks for the reviews done in between the last ping and now!

  * * *

Small patches
=============

* [Patch] Fortran: Extend align-clause checks of OpenMP's allocate clause
   https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608401.html
   Tue Dec 13 16:38:22 GMT 2022

* [Patch] OpenMP: Parse align clause in allocate directive in C/C++
   https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608404.html
   Tue Dec 13 17:44:27 GMT 2022

* Re: [Patch] libgomp.texi: Reverse-offload updates (was: [Patch] libgomp: Handle OpenMP's reverse offloads)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608245.html
   Thu Nov 24 12:01:04 GMT 2022

(Side note: wwwdocs also needs to be updated for the latter patch and
some other patches done in the meanwhile.)


Fortran allocat(e,ors) prep patch
=================================

* [Patch] Fortran/OpenMP: Add parsing support for allocators/allocate directive (was: [Patch] Fortran/OpenMP: Add parsing support for allocators directive)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608904.html
   Wed Dec 21 15:51:25 GMT 2022

(Remark: While written from scratch, it is kind of a follow-up to Abid's patch
    [PATCH 1/5] [gfortran] Add parsing support for allocate directive (OpenMP 5.0)
you/Jakub reviewed on Tue Oct 11 12:13:14 GMT 2022, i.e.
  https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603258.html
- For the actual implementation of 'allocators', we still have to solve the issues
   raised in the review for '[PATCH 2/5] [gfortran] Translate allocate directive (OpenMP 5.0).'.
   at https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603279.html (and earlier in the thread);
   implementing 'omp allocate' (Fortran/C/C++) seems to be easier but no one has started implementing
   it so far - only parsing support exists.
- The USM patches on semi-USM system run into a similar issue as 'allocators' and for it, some
   ME omp_allocate is added.)


Mapping related patches
=======================
(Complex but GCC needs a revision badly as it fixing several bugs and missing functionality.)

* Complete patch set was just re-submitted by Julian, overiew patch is
   [PATCH v6 00/11] OpenMP: C/C++ lvalue parsing, C/C++/Fortran "declare mapper" support
   https://gcc.gnu.org/pipermail/gcc-patches/2022-December/thread.html#609031
   Fri Dec 23 12:12:53 GMT 2022
* Note: For 10/11 of the set, there was a follow up this Monday
   [PATCH v6 10/11] OpenMP: Support OpenMP 5.0 "declare mapper" directives for C
   https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609566.html

[As it relates to one patch in the series:
   '[Patch] Fortran/OpenMP: Fix DT struct-component with 'alloc' and array descr'
That's mine, needs to be updated (WIP) and fixes array descriptor/alloc-string-length var
issues, where descriptor/string length may need to be handled explicitly on data entering map,
i.e. string lengths/allocator may require 'to:' instead of 'alloc:' - and on data exit mapping,
the current code might add a bogus 'alloc:'. - Idea is to handle this explicitly
in fortran/trans-openmp.cc instead of auto-adding it in the ME.
Status: WIP - removed in ME but not all cases are handled yet in FE.)


Fortran deep mapping (allocatable components)
====================
(Old patch of March 2022, but first part now properly but belated submitted - today):
[Patch][1/2] OpenMP: Add lang hooks + run-time filled map arrays for Fortran deep mapping of DT
https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609637.html

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

OpenMP Patch Ping – including "[13 Regression]" patches

[Tobias Burnus]

"[13 Regression]" OpenMP Fortran patches:

[Patch] OpenMP/Fortran: Fix loop-iter var privatization with !$OMP LOOP [PR108512]
https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610531.html

[Patch][v2] OpenMP/Fortran: Partially fix non-rect loop nests [PR107424]
https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610584.html


Additionally, there several more patches pending, see below. Of those:

The first two small ones are very simple; especially the first one I
regard as obvious! The third one is a documentation patch.

The others are of varying complexity but I think some would be still suitable
for the current stage, including some which have been pinged since October :-(

Tobias

PS: The mentioned patches:

On 10.01.23 12:37, Tobias Burnus wrote:
> Hi all, hello Jakub,
>
> Below is the updated list to last ping,
> https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607178.html
>
> NOTE to the list below: I have stopped checking older patches. I know
> some more are pending review, others need to be revised. I will re-check,
> once the below listed patches have been reviewed. Cf. old list.
>
> Thanks for the reviews done in between the last ping and now!
>
>  * * *
>
> Small patches
> =============
>
> * [Patch] Fortran: Extend align-clause checks of OpenMP's allocate clause
> https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608401.html
>   Tue Dec 13 16:38:22 GMT 2022
>
> * [Patch] OpenMP: Parse align clause in allocate directive in C/C++
> https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608404.html
>   Tue Dec 13 17:44:27 GMT 2022
>
> * Re: [Patch] libgomp.texi: Reverse-offload updates (was: [Patch]
> libgomp: Handle OpenMP's reverse offloads)
> https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608245.html
>   Thu Nov 24 12:01:04 GMT 2022
>
> (Side note: wwwdocs also needs to be updated for the latter patch and
> some other patches done in the meanwhile.)
>
>
> Fortran allocat(e,ors) prep patch
> =================================
>
> * [Patch] Fortran/OpenMP: Add parsing support for allocators/allocate
> directive (was: [Patch] Fortran/OpenMP: Add parsing support for
> allocators directive)
> https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608904.html
>   Wed Dec 21 15:51:25 GMT 2022
>
> (Remark: While written from scratch, it is kind of a follow-up to
> Abid's patch
>    [PATCH 1/5] [gfortran] Add parsing support for allocate directive
> (OpenMP 5.0)
> you/Jakub reviewed on Tue Oct 11 12:13:14 GMT 2022, i.e.
>  https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603258.html
> - For the actual implementation of 'allocators', we still have to
> solve the issues
>   raised in the review for '[PATCH 2/5] [gfortran] Translate allocate
> directive (OpenMP 5.0).'.
>   at
> https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603279.html
> (and earlier in the thread);
>   implementing 'omp allocate' (Fortran/C/C++) seems to be easier but
> no one has started implementing
>   it so far - only parsing support exists.
> - The USM patches on semi-USM system run into a similar issue as
> 'allocators' and for it, some
>   ME omp_allocate is added.)
>
>
> Mapping related patches
> =======================
> (Complex but GCC needs a revision badly as it fixing several bugs and
> missing functionality.)
>
> * Complete patch set was just re-submitted by Julian, overiew patch is
>   [PATCH v6 00/11] OpenMP: C/C++ lvalue parsing, C/C++/Fortran
> "declare mapper" support
> https://gcc.gnu.org/pipermail/gcc-patches/2022-December/thread.html#609031
>   Fri Dec 23 12:12:53 GMT 2022
> * Note: For 10/11 of the set, there was a follow up this Monday
>   [PATCH v6 10/11] OpenMP: Support OpenMP 5.0 "declare mapper"
> directives for C
> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609566.html
>
> [As it relates to one patch in the series:
>   '[Patch] Fortran/OpenMP: Fix DT struct-component with 'alloc' and
> array descr'
> That's mine, needs to be updated (WIP) and fixes array
> descriptor/alloc-string-length var
> issues, where descriptor/string length may need to be handled
> explicitly on data entering map,
> i.e. string lengths/allocator may require 'to:' instead of 'alloc:' -
> and on data exit mapping,
> the current code might add a bogus 'alloc:'. - Idea is to handle this
> explicitly
> in fortran/trans-openmp.cc instead of auto-adding it in the ME.
> Status: WIP - removed in ME but not all cases are handled yet in FE.)
>
>
> Fortran deep mapping (allocatable components)
> ====================
> (Old patch of March 2022, but first part now properly but belated
> submitted - today):
> [Patch][1/2] OpenMP: Add lang hooks + run-time filled map arrays for
> Fortran deep mapping of DT
> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609637.html
>
> Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

OpenMP Patch Ping – including "[13 Regression]" patches

[Tobias Burnus]

Updated ping email as some patches have been reviewed. [Thanks! I still
need to revised three of them: for Fortran, the parallel + loop issue
and the non-rect-loop issue - and for C/C++, the allocate's align patch.]

I think it would be very good to get (some of) Julian's mapping patches
in as it fixes several issues; PR108624 is the latest found issue that
is fixed by his set of patches.

Smaller, more recent patches:

* "[Patch] libgomp: Fix reverse-offload for GOMP_MAP_TO_PSET"
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611429.html

* "[PATCH] openmp: Add support for 'present' modifier"
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611299.html

On 10.01.23 12:37, Tobias Burnus wrote [with FYI comments omitted]:

> Fortran allocat(e,ors) prep patch
> =================================
>
> * [Patch] Fortran/OpenMP: Add parsing support for allocators/allocate directive
> https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608904.html>  Wed Dec 21 15:51:25 GMT 2022
>
> Mapping related patches
> =======================
> (Complex but GCC needs a revision badly as it fixing several bugs and
> missing functionality.)
>
> * Complete patch set was just re-submitted by Julian, overiew patch is
>    [PATCH v6 00/11] OpenMP: C/C++ lvalue parsing, C/C++/Fortran "declare mapper" support
>    https://gcc.gnu.org/pipermail/gcc-patches/2022-December/thread.html#609031>  Fri Dec 23 12:12:53 GMT 2022
>
> * Note: For 10/11 of the set, there was a follow up this Monday
>    [PATCH v6 10/11] OpenMP: Support OpenMP 5.0 "declare mapper" directives for C
>    https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609566.html>
>
> Fortran deep mapping (allocatable components)
> ====================
>
> [Patch][1/2] OpenMP: Add lang hooks + run-time filled map arrays for
> Fortran deep mapping of DT
> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609637.html>

Thanks,

Tobias

PS: NOTE to the list above: I have stopped checking older patches. I know
some more are pending review, others need to be revised. I will re-check,
once the below listed patches have been reviewed. Cf. old list.

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

Re: OpenMP Patch Ping – including "[13 Regression]" patches

[Tobias Burnus]

* The 'loop' patch fixes a long-standing bug exposed by a GCC 13 commit,
   making it a "13 Regression" fix
* The next two are simple bug fixes, relatively obvious and have very
   limited-scope code changes - fixing wrong-code issues.
* The next two are a bit longer but also rather contained.
* Julian's patch set fixes several real bugs (such as PR108624), but it unfortunately
   more complex; still, it would be good if they could be eventually be reviewed ...


[Patch][v2] OpenMP/Fortran: Fix loop-iter var privatization with !$OMP LOOP [PR108512]
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611730.html


[Patch] libgomp: Fix 'target enter data' with always pointer
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611920.html

[Patch] libgomp: Fix reverse-offload for GOMP_MAP_TO_PSET
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611429.html


[PATCH] openmp: Add support for 'present' modifier"
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611299.html

[Patch] Fortran/OpenMP: Add parsing support for allocators/allocate directive
https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608904.html


[PATCH v6 00/11] OpenMP: C/C++ lvalue parsing, C/C++/Fortran "declare mapper" support
https://gcc.gnu.org/pipermail/gcc-patches/2022-December/thread.html#609031

Note: For 10/11 of the set, there was a follow up:
[PATCH v6 10/11] OpenMP: Support OpenMP 5.0 "declare mapper" directives for C
https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609566.html


On 07.02.23 17:34, Tobias Burnus wrote:

> On 10.01.23 12:37, Tobias Burnus wrote [with FYI comments omitted]:
> ...
>> Fortran deep mapping (allocatable components)
>>
>> [Patch][1/2] OpenMP: Add lang hooks + run-time filled map arrays for
>> Fortran deep mapping of DT
>> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609637.html
>
> PS: NOTE to the list above: I have stopped checking older patches. I know
> some more are pending review, others need to be revised. I will re-check,
> once the below listed patches have been reviewed. Cf. old list.

Thanks,

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955