* [PATCH] doc: Correct a clerical error in the document.
@ 2022-12-07 1:41 Lulu Cheng
2022-12-07 10:05 ` Richard Sandiford
0 siblings, 1 reply; 3+ messages in thread
From: Lulu Cheng @ 2022-12-07 1:41 UTC (permalink / raw)
To: gcc-patches; +Cc: xry111, i, xuchenghua, Lulu Cheng
gcc/ChangeLog:
* doc/rtl.texi: Correct a clerical error in the document.
---
gcc/doc/rtl.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/doc/rtl.texi b/gcc/doc/rtl.texi
index 43c9ee8bffe..44858d12892 100644
--- a/gcc/doc/rtl.texi
+++ b/gcc/doc/rtl.texi
@@ -2142,7 +2142,7 @@ stores the lower 2 bytes of @var{y} in @var{x} and discards the upper
(set @var{z} (subreg:SI (reg:HI @var{x}) 0))
@end smallexample
-would set the lower two bytes of @var{z} to @var{y} and set the upper
+would set the lower two bytes of @var{z} to @var{x} and set the upper
two bytes to an unknown value assuming @code{SUBREG_PROMOTED_VAR_P} is
false.
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] doc: Correct a clerical error in the document.
2022-12-07 1:41 [PATCH] doc: Correct a clerical error in the document Lulu Cheng
@ 2022-12-07 10:05 ` Richard Sandiford
2022-12-08 1:15 ` Lulu Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Richard Sandiford @ 2022-12-07 10:05 UTC (permalink / raw)
To: Lulu Cheng; +Cc: gcc-patches, xry111, i, xuchenghua
Lulu Cheng <chenglulu@loongson.cn> writes:
> gcc/ChangeLog:
>
> * doc/rtl.texi: Correct a clerical error in the document.
> ---
> gcc/doc/rtl.texi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/doc/rtl.texi b/gcc/doc/rtl.texi
> index 43c9ee8bffe..44858d12892 100644
> --- a/gcc/doc/rtl.texi
> +++ b/gcc/doc/rtl.texi
> @@ -2142,7 +2142,7 @@ stores the lower 2 bytes of @var{y} in @var{x} and discards the upper
> (set @var{z} (subreg:SI (reg:HI @var{x}) 0))
> @end smallexample
>
> -would set the lower two bytes of @var{z} to @var{y} and set the upper
> +would set the lower two bytes of @var{z} to @var{x} and set the upper
> two bytes to an unknown value assuming @code{SUBREG_PROMOTED_VAR_P} is
> false.
Both versions are right in their way. I think the intention of the
original was to show the effect of moving y to z via a paradoxical
subreg on x.
How about:
would set the lower two bytes of @var{z} to @var{x} (which contains
the lower two bytes of @var{y}) and set the upper ...
OK with that change if you agree.
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] doc: Correct a clerical error in the document.
2022-12-07 10:05 ` Richard Sandiford
@ 2022-12-08 1:15 ` Lulu Cheng
0 siblings, 0 replies; 3+ messages in thread
From: Lulu Cheng @ 2022-12-08 1:15 UTC (permalink / raw)
To: gcc-patches, xry111, i, xuchenghua, richard.sandiford
在 2022/12/7 下午6:05, Richard Sandiford 写道:
> Lulu Cheng <chenglulu@loongson.cn> writes:
>> gcc/ChangeLog:
>>
>> * doc/rtl.texi: Correct a clerical error in the document.
>> ---
>> gcc/doc/rtl.texi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/doc/rtl.texi b/gcc/doc/rtl.texi
>> index 43c9ee8bffe..44858d12892 100644
>> --- a/gcc/doc/rtl.texi
>> +++ b/gcc/doc/rtl.texi
>> @@ -2142,7 +2142,7 @@ stores the lower 2 bytes of @var{y} in @var{x} and discards the upper
>> (set @var{z} (subreg:SI (reg:HI @var{x}) 0))
>> @end smallexample
>>
>> -would set the lower two bytes of @var{z} to @var{y} and set the upper
>> +would set the lower two bytes of @var{z} to @var{x} and set the upper
>> two bytes to an unknown value assuming @code{SUBREG_PROMOTED_VAR_P} is
>> false.
> Both versions are right in their way. I think the intention of the
> original was to show the effect of moving y to z via a paradoxical
> subreg on x.
>
> How about:
>
> would set the lower two bytes of @var{z} to @var{x} (which contains
> the lower two bytes of @var{y}) and set the upper ...
>
> OK with that change if you agree.
>
> Richard
Ah, I see. The second test case follows the first test case. :-)
So I think this change is not necessary.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-08 1:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 1:41 [PATCH] doc: Correct a clerical error in the document Lulu Cheng
2022-12-07 10:05 ` Richard Sandiford
2022-12-08 1:15 ` Lulu Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).