* libatomic: drop redundant all-multi command
@ 2022-05-27 8:01 Jan Beulich
2022-05-28 18:25 ` Jeff Law
2022-06-28 6:52 ` Ping: [PATCH] " Jan Beulich
0 siblings, 2 replies; 4+ messages in thread
From: Jan Beulich @ 2022-05-27 8:01 UTC (permalink / raw)
To: gcc-patches
./multilib.am already specifies this same command, and make warns about
the earlier one being ignored when seeing the later one. All that needs
retaining to still satisfy the preceding comment is the extra
dependency.
libatomic/
2022-05-XX Jan Beulich <jbeulich@suse.com>
* Makefile.am (all-multi): Drop commands.
* Makefile.in: Update accordingly.
--- a/libatomic/Makefile.am
+++ b/libatomic/Makefile.am
@@ -147,12 +147,11 @@
libatomic_convenience_la_SOURCES = $(libatomic_la_SOURCES)
libatomic_convenience_la_LIBADD = $(libatomic_la_LIBADD)
-# Override the automake generated all-multi rule to guarantee that all-multi
+# Amend the automake generated all-multi rule to guarantee that all-multi
# is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo
# makefile fragments to avoid broken *.Ppo getting included into the Makefile
# when it is reloaded during the build of all-multi.
all-multi: $(libatomic_la_LIBADD)
- $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE)
# target overrides
-include $(tmake_file)
--- a/libatomic/Makefile.in
+++ b/libatomic/Makefile.in
@@ -858,12 +858,11 @@
%_.lo: Makefile
$(LTCOMPILE) $(M_DEPS) $(M_SIZE) $(M_IFUNC) -c -o $@ $(M_SRC)
-# Override the automake generated all-multi rule to guarantee that all-multi
+# Amend the automake generated all-multi rule to guarantee that all-multi
# is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo
# makefile fragments to avoid broken *.Ppo getting included into the Makefile
# when it is reloaded during the build of all-multi.
all-multi: $(libatomic_la_LIBADD)
- $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE)
# target overrides
-include $(tmake_file)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: libatomic: drop redundant all-multi command
2022-05-27 8:01 libatomic: drop redundant all-multi command Jan Beulich
@ 2022-05-28 18:25 ` Jeff Law
2022-06-28 6:52 ` Ping: [PATCH] " Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Law @ 2022-05-28 18:25 UTC (permalink / raw)
To: gcc-patches
On 5/27/2022 2:01 AM, Jan Beulich via Gcc-patches wrote:
> ./multilib.am already specifies this same command, and make warns about
> the earlier one being ignored when seeing the later one. All that needs
> retaining to still satisfy the preceding comment is the extra
> dependency.
>
> libatomic/
> 2022-05-XX Jan Beulich <jbeulich@suse.com>
>
> * Makefile.am (all-multi): Drop commands.
> * Makefile.in: Update accordingly.
OK for the trunk.
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Ping: [PATCH] libatomic: drop redundant all-multi command
2022-05-27 8:01 libatomic: drop redundant all-multi command Jan Beulich
2022-05-28 18:25 ` Jeff Law
@ 2022-06-28 6:52 ` Jan Beulich
2022-06-28 16:06 ` Jeff Law
1 sibling, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2022-06-28 6:52 UTC (permalink / raw)
To: gcc-patches; +Cc: bonzini, neroden, aoliva, Ralf.Wildenhues
On 27.05.2022 10:01, Jan Beulich wrote:
> ./multilib.am already specifies this same command, and make warns about
> the earlier one being ignored when seeing the later one. All that needs
> retaining to still satisfy the preceding comment is the extra
> dependency.
>
> libatomic/
>
> * Makefile.am (all-multi): Drop commands.
> * Makefile.in: Update accordingly.
Ping?
Thanks, Jan
> --- a/libatomic/Makefile.am
> +++ b/libatomic/Makefile.am
> @@ -147,12 +147,11 @@
> libatomic_convenience_la_SOURCES = $(libatomic_la_SOURCES)
> libatomic_convenience_la_LIBADD = $(libatomic_la_LIBADD)
>
> -# Override the automake generated all-multi rule to guarantee that all-multi
> +# Amend the automake generated all-multi rule to guarantee that all-multi
> # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo
> # makefile fragments to avoid broken *.Ppo getting included into the Makefile
> # when it is reloaded during the build of all-multi.
> all-multi: $(libatomic_la_LIBADD)
> - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE)
>
> # target overrides
> -include $(tmake_file)
> --- a/libatomic/Makefile.in
> +++ b/libatomic/Makefile.in
> @@ -858,12 +858,11 @@
> %_.lo: Makefile
> $(LTCOMPILE) $(M_DEPS) $(M_SIZE) $(M_IFUNC) -c -o $@ $(M_SRC)
>
> -# Override the automake generated all-multi rule to guarantee that all-multi
> +# Amend the automake generated all-multi rule to guarantee that all-multi
> # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo
> # makefile fragments to avoid broken *.Ppo getting included into the Makefile
> # when it is reloaded during the build of all-multi.
> all-multi: $(libatomic_la_LIBADD)
> - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE)
>
> # target overrides
> -include $(tmake_file)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Ping: [PATCH] libatomic: drop redundant all-multi command
2022-06-28 6:52 ` Ping: [PATCH] " Jan Beulich
@ 2022-06-28 16:06 ` Jeff Law
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Law @ 2022-06-28 16:06 UTC (permalink / raw)
To: gcc-patches
On 6/28/2022 12:52 AM, Jan Beulich via Gcc-patches wrote:
> On 27.05.2022 10:01, Jan Beulich wrote:
>> ./multilib.am already specifies this same command, and make warns about
>> the earlier one being ignored when seeing the later one. All that needs
>> retaining to still satisfy the preceding comment is the extra
>> dependency.
>>
>> libatomic/
>>
>> * Makefile.am (all-multi): Drop commands.
>> * Makefile.in: Update accordingly.
> Ping?
Weird, I thought I'd acked this already, but I can't find it in my outbox.
OK for the trunk.
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-28 16:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-27 8:01 libatomic: drop redundant all-multi command Jan Beulich
2022-05-28 18:25 ` Jeff Law
2022-06-28 6:52 ` Ping: [PATCH] " Jan Beulich
2022-06-28 16:06 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).