* [PATCH] --target-help: align with --help=target
@ 2022-03-31 6:56 Martin Liška
2022-04-06 15:27 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Martin Liška @ 2022-03-31 6:56 UTC (permalink / raw)
To: gcc-patches
Hi.
Before the patch we have:
$ gcc-11 --help | grep target-help
--target-help Display target specific command line options.
$ gcc-11 --help=common | grep target-help
--target-help Alias for --help=target.
and --target-help prints undocumented options (that was reported in the PR).
After my change we do:
$ gcc --help | grep target-help
--target-help Display target specific command line options (including assembler and linker options).
$ gcc --help=common | grep target-help
--target-help Display target specific command line options (including assembler and linker options).
and the undocumented options are not printed.
Ready to be installed after tests?
Thanks,
Martin
PR driver/105096
gcc/ChangeLog:
* common.opt: Document properly based on what it does.
* gcc.cc (display_help): Unify with what we have in common.opt.
* opts.cc (common_handle_option): Do not print undocumented
options.
---
gcc/common.opt | 2 +-
gcc/gcc.cc | 3 ++-
gcc/opts.cc | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/gcc/common.opt b/gcc/common.opt
index 8b6513de47c..8a0dafc522d 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -419,7 +419,7 @@ Driver Alias(symbolic)
-target-help
Common Driver
-Alias for --help=target.
+Display target specific command line options (including assembler and linker options).
-time
Driver Alias(time)
diff --git a/gcc/gcc.cc b/gcc/gcc.cc
index a4d863ca457..bb07cc244e3 100644
--- a/gcc/gcc.cc
+++ b/gcc/gcc.cc
@@ -3758,7 +3758,8 @@ display_help (void)
fputs (_(" -pass-exit-codes Exit with highest error code from a phase.\n"), stdout);
fputs (_(" --help Display this information.\n"), stdout);
- fputs (_(" --target-help Display target specific command line options.\n"), stdout);
+ fputs (_(" --target-help Display target specific command line options "
+ "(including assembler and linker options).\n"), stdout);
fputs (_(" --help={common|optimizers|params|target|warnings|[^]{joined|separate|undocumented}}[,...].\n"), stdout);
fputs (_(" Display specific types of command line options.\n"), stdout);
if (! verbose_flag)
diff --git a/gcc/opts.cc b/gcc/opts.cc
index ef5fe9b11ca..e5e3119a980 100644
--- a/gcc/opts.cc
+++ b/gcc/opts.cc
@@ -2557,7 +2557,7 @@ common_handle_option (struct gcc_options *opts,
break;
target_option_override_hook ();
- print_specific_help (CL_TARGET, CL_UNDOCUMENTED, 0, opts, lang_mask);
+ print_specific_help (CL_TARGET, 0, 0, opts, lang_mask);
opts->x_exit_after_options = true;
break;
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] --target-help: align with --help=target
2022-03-31 6:56 [PATCH] --target-help: align with --help=target Martin Liška
@ 2022-04-06 15:27 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2022-04-06 15:27 UTC (permalink / raw)
To: gcc-patches
On 3/31/2022 12:56 AM, Martin Liška wrote:
> Hi.
>
> Before the patch we have:
>
> $ gcc-11 --help | grep target-help
> --target-help Display target specific command line options.
> $ gcc-11 --help=common | grep target-help
> --target-help Alias for --help=target.
>
> and --target-help prints undocumented options (that was reported in
> the PR).
>
> After my change we do:
>
> $ gcc --help | grep target-help
> --target-help Display target specific command line
> options (including assembler and linker options).
> $ gcc --help=common | grep target-help
> --target-help Display target specific command line
> options (including assembler and linker options).
>
> and the undocumented options are not printed.
>
> Ready to be installed after tests?
> Thanks,
> Martin
>
> PR driver/105096
>
> gcc/ChangeLog:
>
> * common.opt: Document properly based on what it does.
> * gcc.cc (display_help): Unify with what we have in common.opt.
> * opts.cc (common_handle_option): Do not print undocumented
> options.
OK
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31 6:56 [PATCH] --target-help: align with --help=target Martin Liška
2022-04-06 15:27 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).