From: Jeff Law <jeffreyalaw@gmail.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH] gcc: m68k: fix PR target/107645
Date: Tue, 15 Nov 2022 20:33:13 -0700 [thread overview]
Message-ID: <7c27f8ea-38c2-a946-d281-4a35e03e8e83@gmail.com> (raw)
In-Reply-To: <CAMo8BfK-tRBEKbZ_t+xzTT7UL2W68+27DEZcEM2nDNKu86h-XQ@mail.gmail.com>
On 11/12/22 20:47, Max Filippov wrote:
> On Sat, Nov 12, 2022 at 11:42 AM Jeff Law <jeffreyalaw@gmail.com> wrote:
>> ISTM that we'd need to strip the unspec and process its argument
>> instead.
> I tried that first, the result was more ICEs because that pattern
> wasn't recognized at later stages. Then I read the change to the
> comment over the symbolic_operand predicate:
> https://gcc.gnu.org/git/?p=gcc.git;a=blobdiff;f=gcc/config/m68k/predicates.md;h=6ca261fb92a2b7ecd53a0356d06410e2c0d70965;hp=417989f6d6c408fa82af9f9649a204b9a754d1dc;hb=75df395f15f2;hpb=676fd528c9990a4f1046b51d40059893c3a71490
> and that made me think that the intention was to not recognize
> the unspecs in that predicate.
Thanks for clarifying. ISTM that operand predicate is quite poorly named.
OK for the trunk.
jeff
next prev parent reply other threads:[~2022-11-16 3:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 19:43 Max Filippov
2022-11-12 19:42 ` Jeff Law
2022-11-13 3:47 ` Max Filippov
2022-11-16 3:33 ` Jeff Law [this message]
2022-11-16 12:37 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c27f8ea-38c2-a946-d281-4a35e03e8e83@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jcmvbkbc@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).