From: Jeff Law <jeffreyalaw@gmail.com>
To: Max Filippov <jcmvbkbc@gmail.com>, gcc-patches@gcc.gnu.org
Cc: Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH] gcc: m68k: fix PR target/107645
Date: Sat, 12 Nov 2022 12:42:41 -0700 [thread overview]
Message-ID: <80a301f3-6b42-cbad-77b9-cc219eed54ce@gmail.com> (raw)
In-Reply-To: <20221111194356.3922768-1-jcmvbkbc@gmail.com>
On 11/11/22 12:43, Max Filippov wrote:
> gcc/
> PR target/107645
> * config/m68k/predicates.md (symbolic_operand): Return false
> when UNSPEC is under the CONST node.
Isn't the underlying object still symbolic though, thus returning false
seems wrong.
insn 342 341 343 35 (set (reg:SI 97)
(mem/u:SI (plus:SI (reg:SI 13 %a5)
(const:SI (unspec:SI [
(symbol_ref:SI
("__gcov_kvp_dynamic_pool_index") [flags 0x40] <var_decl 0x7f9e83fe7cf0
__gcov_kvp_dynamic_pool_index>)
(const_int 0 [0])
] 6))) [0 S4 A8]))
"gcc/libgcc/libgcov.h":472:44 55 {*movsi_m68k2}
(expr_list:REG_EQUAL (symbol_ref:SI
("__gcov_kvp_dynamic_pool_index") [flags 0x40] <var_decl 0x7f9e83fe7cf0
__gcov_kvp_dynamic_pool_index>)
(nil)))
ISTM that we'd need to strip the unspec and process its argument
instead. But maybe I'm missing something.
jeff
next prev parent reply other threads:[~2022-11-12 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 19:43 Max Filippov
2022-11-12 19:42 ` Jeff Law [this message]
2022-11-13 3:47 ` Max Filippov
2022-11-16 3:33 ` Jeff Law
2022-11-16 12:37 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80a301f3-6b42-cbad-77b9-cc219eed54ce@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jcmvbkbc@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).