*ping* Re: [Patch] OpenMP: Fix reverse offload GOMP_TARGET_REV IFN corner cases [PR107236]

[Tobias Burnus <tobias@codesourcery.com>]

Ping this patch – and also "Re: [Patch][v5] libgomp/nvptx: Prepare for
reverse-offload callback handling".

For the latter cf. Alexander's code approval
https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603908.html – and
his concerns regarding the generic feature in
https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601959.html (I
think 'target nowait' permits what he thinks is the better way for GPUs.)

Tobias

On 18.10.22 21:27, Tobias Burnus wrote:
> Found when playing around with reverse offload once I used 'omp target
> parallel'.
> The other issue showed up when running the testsuite (which is done
> with -O2).
>
> In all cases, the ICE is in expand_GOMP_TARGET_REV of this IFN, which
> should
> be unreachable
>
> Note: ENABLE_OFFLOADING inside the compiler must evaluate to true to
> show up
> as ICE - otherwise, the IFN is not even generated.
>
> I did not see a good reason for DECL_CONTEXT = NULL, thus, I now set
> it to
> the same as was set for child_fn - for no good reason.
>
> Tested on x86-64 with ENABLE_OFFLOADING albeit without true offloading.
> OK for mainline?
>
> Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955