From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] OpenMP: Fix reverse offload GOMP_TARGET_REV IFN corner cases [PR107236]
Date: Mon, 24 Oct 2022 15:14:34 +0200 [thread overview]
Message-ID: <Y1aPuhJy1NrYQ5Wq@tucnak> (raw)
In-Reply-To: <9e2d0331-92c4-c8a6-a662-61f298fb3976@codesourcery.com>
On Tue, Oct 18, 2022 at 09:27:04PM +0200, Tobias Burnus wrote:
> The cgraph_node::create_clone issue is exposed with -O2 for the existing
> libgomp.fortran/reverse-offload-1.f90.
>
> omp-offload.cc
>
> PR middle-end/107236
>
> gcc/ChangeLog:
> * omp-expand.cc (expand_omp_target): Set calls_declare_variant_alt
> in DECL_CONTEXT and not to cfun->decl.
> * cgraphclones.cc (cgraph_node::create_clone): Copy also the
> node's calls_declare_variant_alt value.
>
> gcc/testsuite/ChangeLog:
> * gfortran.dg/gomp/target-device-ancestor-6.f90: New test.
LGTM, thanks.
Jakub
prev parent reply other threads:[~2022-10-24 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 19:27 Tobias Burnus
2022-10-24 7:47 ` *ping* " Tobias Burnus
2022-10-24 13:14 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1aPuhJy1NrYQ5Wq@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).