From: Jiufu Guo <guojiufu@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Richard Biener <rguenther@suse.de>,
gcc-patches@gcc.gnu.org, dje.gcc@gmail.com, linkw@gcc.gnu.org,
jeffreyalaw@gmail.com
Subject: Re: [PATCH] loading float member of parameter stored via int registers
Date: Fri, 23 Dec 2022 20:23:59 +0800 [thread overview]
Message-ID: <7e5ye2gvfk.fsf@pike.rch.stglabs.ibm.com> (raw)
In-Reply-To: <20221222184054.GW25951@gate.crashing.org> (Segher Boessenkool's message of "Thu, 22 Dec 2022 12:40:54 -0600")
Hi,
Segher Boessenkool <segher@kernel.crashing.org> writes:
> On Thu, Dec 22, 2022 at 11:28:01AM +0000, Richard Biener wrote:
>> On Thu, 22 Dec 2022, Jiufu Guo wrote:
>> > To reduce risk, I'm just draft straightforward patches for
>> > special cases currently, Like:
>> > https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608081.html
>> > and this patch.
>>
>> Heh, yes - though I'm not fond of special-casing things. RTL
>> expansion is already full of special cases :/
>
> And many of those are not useful at all (would be done by later passes),
> or are actively harmful. Not to mention that expand is currently one of
> the most impregnable and undebuggable RTL passes.
>
> But there are also many things done during expand that although they
> should be done somewhat later, aren't actually done later at all
> currently. So that needs fixing.
>
> Maybe things should go via an intermediate step, where all the decisions
> can be made, and then later we just have to translate the "low Gimple"
> or "RTL-Gimple" ("Rimple"?) to RTL. A format that is looser in many
> ways than either RTL or Gimple. A bit like Generic in that way.
Thanks for all your great comments!
BR,
Jeff (Jiufu)
>
>
> Segher
next prev parent reply other threads:[~2022-12-23 12:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 6:27 Jiufu Guo
2022-12-21 7:30 ` Richard Biener
2022-12-22 7:25 ` guojiufu
2022-12-22 7:54 ` Richard Biener
2022-12-22 9:02 ` Jiufu Guo
2022-12-22 11:28 ` Richard Biener
2022-12-22 18:40 ` Segher Boessenkool
2022-12-23 12:23 ` Jiufu Guo [this message]
2022-12-23 12:36 ` Jiufu Guo
2022-12-23 14:45 ` Segher Boessenkool
2022-12-23 16:20 ` Richard Biener
2022-12-23 16:52 ` Segher Boessenkool
2022-12-23 19:13 ` Richard Biener
2022-12-23 19:52 ` Segher Boessenkool
2022-12-27 3:03 ` Jiufu Guo
2022-12-27 14:16 ` Jiufu Guo
2022-12-30 2:22 ` Jiufu Guo
2022-12-30 7:44 ` Segher Boessenkool
2022-12-30 8:30 ` Andrew Pinski
2023-01-03 3:28 ` Jiufu Guo
2023-01-03 8:59 ` Segher Boessenkool
2023-01-03 9:10 ` Hu, Lin1
2022-12-27 2:15 ` Jiufu Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e5ye2gvfk.fsf@pike.rch.stglabs.ibm.com \
--to=guojiufu@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=linkw@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).