* [COMMITTED] bpf: add pseudo-c asm dialect for "nop"
@ 2023-07-24 19:08 David Faust
2023-07-25 11:46 ` Jose E. Marchesi
0 siblings, 1 reply; 2+ messages in thread
From: David Faust @ 2023-07-24 19:08 UTC (permalink / raw)
To: gcc-patches; +Cc: jose.marchesi, cupertino.miranda
The define_insn "nop" was missing a template for the pseudo-c dialect,
so the normal syntax was unconditionally emitted.
Tested on bpf-unknown-none, committed as obvious.
gcc/
* config/bpf/bpf.md (nop): Add pseudo-c asm dialect template.
---
gcc/config/bpf/bpf.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
index 3e2d760fbe4..64342ea1de2 100644
--- a/gcc/config/bpf/bpf.md
+++ b/gcc/config/bpf/bpf.md
@@ -103,7 +103,7 @@ (define_mode_attr msuffix [(SI "32") (DI "")])
(define_insn "nop"
[(const_int 0)]
""
- "ja\t0"
+ "{ja\t0|goto 0}"
[(set_attr "type" "alu")])
;;;; Arithmetic/Logical
--
2.40.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [COMMITTED] bpf: add pseudo-c asm dialect for "nop"
2023-07-24 19:08 [COMMITTED] bpf: add pseudo-c asm dialect for "nop" David Faust
@ 2023-07-25 11:46 ` Jose E. Marchesi
0 siblings, 0 replies; 2+ messages in thread
From: Jose E. Marchesi @ 2023-07-25 11:46 UTC (permalink / raw)
To: David Faust; +Cc: gcc-patches, cupertino.miranda
> The define_insn "nop" was missing a template for the pseudo-c dialect,
> so the normal syntax was unconditionally emitted.
Thank you.
> Tested on bpf-unknown-none, committed as obvious.
>
> gcc/
>
> * config/bpf/bpf.md (nop): Add pseudo-c asm dialect template.
> ---
> gcc/config/bpf/bpf.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
> index 3e2d760fbe4..64342ea1de2 100644
> --- a/gcc/config/bpf/bpf.md
> +++ b/gcc/config/bpf/bpf.md
> @@ -103,7 +103,7 @@ (define_mode_attr msuffix [(SI "32") (DI "")])
> (define_insn "nop"
> [(const_int 0)]
> ""
> - "ja\t0"
> + "{ja\t0|goto 0}"
> [(set_attr "type" "alu")])
>
> ;;;; Arithmetic/Logical
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-25 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-24 19:08 [COMMITTED] bpf: add pseudo-c asm dialect for "nop" David Faust
2023-07-25 11:46 ` Jose E. Marchesi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).