* [PATCH] Fix spurious match in extract_symvers
@ 2024-01-09 21:46 Andreas Schwab
2024-01-09 22:01 ` Jonathan Wakely
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2024-01-09 21:46 UTC (permalink / raw)
To: libstdc++; +Cc: gcc-patches
Tighten the regex to find the start of the .dynsym symtab in the readelf
output to avoid matching the section symbol in the normal symtab.
libstdc++-v3:
* scripts/extract_symvers.in: Require final colon to only match
.dsynsym in the header of the dynamic symtab.
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/libstdc++-v3/scripts/extract_symvers.in b/libstdc++-v3/scripts/extract_symvers.in
index 17f0d31bd1c..6bb951c7145 100755
--- a/libstdc++-v3/scripts/extract_symvers.in
+++ b/libstdc++-v3/scripts/extract_symvers.in
@@ -52,7 +52,7 @@ SunOS)
# Omit _DYNAMIC etc. for consistency with extract_symvers.pl, only
# present on Solaris.
${readelf} ${lib} |\
- sed -e 's/ \[<other>: [A-Fa-f0-9]*\] //' -e '/\.dynsym/,/^$/p;d' |\
+ sed -e 's/ \[<other>: [A-Fa-f0-9]*\] //' -e '/\.dynsym.*:$/,/^$/p;d' |\
sed -e 's/ \[<localentry>: [0-9]*\] //' |\
grep -E -v ' (LOCAL|UND) ' |\
grep -E -v ' (_DYNAMIC|_GLOBAL_OFFSET_TABLE_|_PROCEDURE_LINKAGE_TABLE_|_edata|_end|_etext)$' |\
--
2.43.0
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Fix spurious match in extract_symvers
2024-01-09 21:46 [PATCH] Fix spurious match in extract_symvers Andreas Schwab
@ 2024-01-09 22:01 ` Jonathan Wakely
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2024-01-09 22:01 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libstdc++, gcc-patches
On Tue, 9 Jan 2024 at 21:47, Andreas Schwab wrote:
>
> Tighten the regex to find the start of the .dynsym symtab in the readelf
> output to avoid matching the section symbol in the normal symtab.
OK, thanks.
>
> libstdc++-v3:
> * scripts/extract_symvers.in: Require final colon to only match
> .dsynsym in the header of the dynamic symtab.
> ---
> libstdc++-v3/scripts/extract_symvers.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/scripts/extract_symvers.in b/libstdc++-v3/scripts/extract_symvers.in
> index 17f0d31bd1c..6bb951c7145 100755
> --- a/libstdc++-v3/scripts/extract_symvers.in
> +++ b/libstdc++-v3/scripts/extract_symvers.in
> @@ -52,7 +52,7 @@ SunOS)
> # Omit _DYNAMIC etc. for consistency with extract_symvers.pl, only
> # present on Solaris.
> ${readelf} ${lib} |\
> - sed -e 's/ \[<other>: [A-Fa-f0-9]*\] //' -e '/\.dynsym/,/^$/p;d' |\
> + sed -e 's/ \[<other>: [A-Fa-f0-9]*\] //' -e '/\.dynsym.*:$/,/^$/p;d' |\
> sed -e 's/ \[<localentry>: [0-9]*\] //' |\
> grep -E -v ' (LOCAL|UND) ' |\
> grep -E -v ' (_DYNAMIC|_GLOBAL_OFFSET_TABLE_|_PROCEDURE_LINKAGE_TABLE_|_edata|_end|_etext)$' |\
> --
> 2.43.0
>
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-09 22:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-09 21:46 [PATCH] Fix spurious match in extract_symvers Andreas Schwab
2024-01-09 22:01 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).