From: Gaius Mulley <gaiusmod2@gmail.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] modula2/108144 - Fix multilib install of libgm2
Date: Fri, 20 Jan 2023 18:39:24 +0000 [thread overview]
Message-ID: <87zgad82zn.fsf@debian> (raw)
In-Reply-To: <63ca8324.170a0220.3a893.0660SMTPIN_ADDED_MISSING@mx.google.com> (Richard Biener's message of "Fri, 20 Jan 2023 13:03:47 +0100 (CET)")
Richard Biener <rguenther@suse.de> writes:
> The following adjusts libgm2 to properly use the multilib build
> infrastructure, thereby fixing the install with
> --enable-version-specific-runtime-libs
>
> In particular config-ml.pl needs to be applied to generated Makefiles
> as documented in the manual and we have to avoid clobbering the
> variables via make arguments. The explicit install rules used different
> ways to construct the multilib dir which isn't necessary and breaks
> when MUTLIDIR is now finally set correctly. Instead use
> $(toolexeclibdir).
>
> This results in some dead variables in the Makefile.am (and there were
> some before), I refrained from doing even more changes here.
>
> Verified with an install with and without --enable-version-specific-runtime-libs
> and checking the result.
>
> OK?
>
> Thanks,
> Richard.
Many thanks for this fix - and the deep magic AC_FOREACH config-ml.in
recursion rhunes. LGTM
regards,
Gaius
next parent reply other threads:[~2023-01-20 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <63ca8324.170a0220.3a893.0660SMTPIN_ADDED_MISSING@mx.google.com>
2023-01-20 18:39 ` Gaius Mulley [this message]
2023-01-20 18:49 ` NightStrike
2023-01-23 7:26 ` Richard Biener
2023-01-20 12:03 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgad82zn.fsf@debian \
--to=gaiusmod2@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).