Re: [PATCH] modula2/108144 - Fix multilib install of libgm2

[Richard Biener <rguenther@suse.de>]

On Fri, 20 Jan 2023, NightStrike wrote:

> On Fri, Jan 20, 2023 at 1:40 PM Gaius Mulley via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> > Richard Biener <rguenther@suse.de> writes:
> >
> > > The following adjusts libgm2 to properly use the multilib build
> > > infrastructure, thereby fixing the install with
> > > --enable-version-specific-runtime-libs
> > >
> > > In particular config-ml.pl needs to be applied to generated Makefiles
> > > as documented in the manual and we have to avoid clobbering the
> > > variables via make arguments.  The explicit install rules used different
> > > ways to construct the multilib dir which isn't necessary and breaks
> > > when MUTLIDIR is now finally set correctly.  Instead use
> > > $(toolexeclibdir).
> > >
> > > This results in some dead variables in the Makefile.am (and there were
> > > some before), I refrained from doing even more changes here.
> > >
> > > Verified with an install with and without --enable-version-specific-runtime-libs
> > > and checking the result.
> > >
> > > OK?
> > >
> > > Thanks,
> > > Richard.
> >
> > Many thanks for this fix - and the deep magic AC_FOREACH config-ml.in
> > recursion rhunes.  LGTM
> >
> > regards,
> > Gaius
> 
> AC_FOREACH is obsolete and shouldn't be used in new code.  It's been
> replaced with m4_foreach_w:
> https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Obsolete-Macros.html

I've pushed with AC_FOREACH which I cut&pasted from elsewhere.  If
somebody feels like replacing all AC_FOREACH in the tree then that's
of course good.

Richard.