public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andreas Krebbel <krebbel@linux.ibm.com>
To: Robin Dapp <rdapp@linux.ibm.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] s390: Add more vcond_mask patterns.
Date: Wed, 9 Jun 2021 17:14:53 +0200	[thread overview]
Message-ID: <97b26a18-9c14-b2ca-e021-0fbbeb92ed94@linux.ibm.com> (raw)
In-Reply-To: <e33e4f1b-5eed-f252-559a-df5239ef559e@linux.ibm.com>

On 6/9/21 2:47 PM, Robin Dapp wrote:
>> I think the real problem is the expander name. That's why it could not be found by optab. The second
>> mode needs to be the int vector mode of op3. With that change the testcases work as expected:
>>
>> diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md
>> index c80d582a300d..ab605b3d2cf3 100644
>> --- a/gcc/config/s390/vector.md
>> +++ b/gcc/config/s390/vector.md
>> @@ -715,7 +715,7 @@
>>     DONE;
>>   })
>>
>> -(define_expand "vcond_mask_<mode><mode>"
>> +(define_expand "vcond_mask_<mode><tointvec>"
>>     [(set (match_operand:V 0 "register_operand" "")
>>          (if_then_else:V
>>           (eq (match_operand:<TOINTVEC> 3 "register_operand" "")
> 
> Ah, yes, it's indeed much simpler that way.  Attached the revised 
> version with the small change and the new tests as a single patch now.
> 
> Regtest and bootstrap was successful.

Ok. Thanks!

Andreas

      reply	other threads:[~2021-06-09 15:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 15:18 Robin Dapp
2021-05-11 12:40 ` Andreas Krebbel
2021-06-09 12:47   ` Robin Dapp
2021-06-09 15:14     ` Andreas Krebbel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97b26a18-9c14-b2ca-e021-0fbbeb92ed94@linux.ibm.com \
    --to=krebbel@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rdapp@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).