public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH v1] RISC-V: Fix one typo in full-vec-movel test
@ 2023-06-13  7:17 pan2.li
  2023-06-13  7:20 ` Robin Dapp
  0 siblings, 1 reply; 5+ messages in thread
From: pan2.li @ 2023-06-13  7:17 UTC (permalink / raw)
  To: gcc-patches
  Cc: juzhe.zhong, rdapp.gcc, jeffreyalaw, pan2.li, yanzhang.wang, kito.cheng

From: Pan Li <pan2.li@intel.com>

This patch would like to fix one typo when checking assembly of
full-vec-movel.

Signed-off-by: Pan Li <pan2.li@intel.com>

gcc/testsuite/ChangeLog:

	* gcc.target/riscv/rvv/autovec/vls-vlmax/full-vec-move1.c:
	Adjust dg-do to comiple for asm checking.
---
 .../gcc.target/riscv/rvv/autovec/vls-vlmax/full-vec-move1.c     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/full-vec-move1.c b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/full-vec-move1.c
index c1119cddee7..c32c31ecd69 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/full-vec-move1.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/full-vec-move1.c
@@ -1,4 +1,4 @@
-/* { dg-do run { target { riscv_vector } } } */
+/* { dg-do compile } */
 /* { dg-additional-options "-std=c99 -O3 -march=rv64gcv_zvl128b -fno-vect-cost-model --param=riscv-autovec-preference=fixed-vlmax" } */
 
 #include <stdint-gcc.h>
-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] RISC-V: Fix one typo in full-vec-movel test
  2023-06-13  7:17 [PATCH v1] RISC-V: Fix one typo in full-vec-movel test pan2.li
@ 2023-06-13  7:20 ` Robin Dapp
  2023-06-13  7:21   ` juzhe.zhong
  0 siblings, 1 reply; 5+ messages in thread
From: Robin Dapp @ 2023-06-13  7:20 UTC (permalink / raw)
  To: pan2.li, gcc-patches
  Cc: rdapp.gcc, juzhe.zhong, jeffreyalaw, yanzhang.wang, kito.cheng

> This patch would like to fix one typo when checking assembly of
> full-vec-movel.

OK.  (I actually intended to commit this myself adding some more
comments to the iterator change as well as fix the tests, but well...)

Regards
 Robin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Re: [PATCH v1] RISC-V: Fix one typo in full-vec-movel test
  2023-06-13  7:20 ` Robin Dapp
@ 2023-06-13  7:21   ` juzhe.zhong
  2023-06-13  7:23     ` Robin Dapp
  0 siblings, 1 reply; 5+ messages in thread
From: juzhe.zhong @ 2023-06-13  7:21 UTC (permalink / raw)
  To: Robin Dapp, pan2.li, gcc-patches
  Cc: Robin Dapp, jeffreyalaw, yanzhang.wang, kito.cheng

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Oh. Sorry. Since I want to commit my patch so I asked Pan to commit your test as well.
I think you can resend a fix of this testcase and drop this patch.



juzhe.zhong@rivai.ai
 
From: Robin Dapp
Date: 2023-06-13 15:20
To: pan2.li; gcc-patches
CC: rdapp.gcc; juzhe.zhong; jeffreyalaw; yanzhang.wang; kito.cheng
Subject: Re: [PATCH v1] RISC-V: Fix one typo in full-vec-movel test
> This patch would like to fix one typo when checking assembly of
> full-vec-movel.
 
OK.  (I actually intended to commit this myself adding some more
comments to the iterator change as well as fix the tests, but well...)
 
Regards
Robin
 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] RISC-V: Fix one typo in full-vec-movel test
  2023-06-13  7:21   ` juzhe.zhong
@ 2023-06-13  7:23     ` Robin Dapp
  2023-06-13  7:27       ` Li, Pan2
  0 siblings, 1 reply; 5+ messages in thread
From: Robin Dapp @ 2023-06-13  7:23 UTC (permalink / raw)
  To: juzhe.zhong, pan2.li, gcc-patches
  Cc: rdapp.gcc, jeffreyalaw, yanzhang.wang, kito.cheng

> Oh. Sorry. Since I want to commit my patch so I asked Pan to commit
> your test as well. I think you can resend a fix of this testcase and
> drop this patch.

No problem, will fix it another time.  Pan can just go ahead with this
fix now, no need to wait for a maintainer, it's obvious enough.

Thanks
 Robin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH v1] RISC-V: Fix one typo in full-vec-movel test
  2023-06-13  7:23     ` Robin Dapp
@ 2023-06-13  7:27       ` Li, Pan2
  0 siblings, 0 replies; 5+ messages in thread
From: Li, Pan2 @ 2023-06-13  7:27 UTC (permalink / raw)
  To: Robin Dapp, juzhe.zhong, gcc-patches
  Cc: jeffreyalaw, Wang, Yanzhang, kito.cheng

Committed, thanks Robin and Juzhe.

Pan

-----Original Message-----
From: Robin Dapp <rdapp.gcc@gmail.com> 
Sent: Tuesday, June 13, 2023 3:24 PM
To: juzhe.zhong@rivai.ai; Li, Pan2 <pan2.li@intel.com>; gcc-patches <gcc-patches@gcc.gnu.org>
Cc: rdapp.gcc@gmail.com; jeffreyalaw <jeffreyalaw@gmail.com>; Wang, Yanzhang <yanzhang.wang@intel.com>; kito.cheng <kito.cheng@gmail.com>
Subject: Re: [PATCH v1] RISC-V: Fix one typo in full-vec-movel test

> Oh. Sorry. Since I want to commit my patch so I asked Pan to commit 
> your test as well. I think you can resend a fix of this testcase and 
> drop this patch.

No problem, will fix it another time.  Pan can just go ahead with this fix now, no need to wait for a maintainer, it's obvious enough.

Thanks
 Robin

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-06-13  7:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-13  7:17 [PATCH v1] RISC-V: Fix one typo in full-vec-movel test pan2.li
2023-06-13  7:20 ` Robin Dapp
2023-06-13  7:21   ` juzhe.zhong
2023-06-13  7:23     ` Robin Dapp
2023-06-13  7:27       ` Li, Pan2

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).