From: Sandra Loosemore <sandra@codesourcery.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
Sean Bright <sean@seanbright.com>,
Gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] docs: Fix double 'See' in zero-length-bounds docs.
Date: Sun, 12 Mar 2023 13:32:47 -0600 [thread overview]
Message-ID: <99de2404-430d-954a-7f0c-63c98238aed1@codesourcery.com> (raw)
In-Reply-To: <11A5528F-9B3F-4F35-8CEF-BA2FF28DA3DA@gmail.com>
On 3/12/23 01:12, Bernhard Reutner-Fischer via Gcc-patches wrote:
> On 12 March 2023 03:47:08 CET, Sean Bright via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>> On 3/11/2023 6:39 PM, Bernhard Reutner-Fischer wrote:
>>> On 11 March 2023 18:33:46 CET, Sean Bright via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>>>> Hi,
>>>>
>>>> This fixes a minor issue where the zero-length-bound docs read "See See
>>>> Zero Length."
>>>>
>>>> gcc/ChangeLog:
>>>> * doc/invoke.texi (Warning Options): Remove errant 'See'
>>>> before @xref.
>>>> ---
>>>> gcc/doc/invoke.texi | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
>>>> index 3a6a97862b0..174d160dd6c 100644
>>>> --- a/gcc/doc/invoke.texi
>>>> +++ b/gcc/doc/invoke.texi
>>>> @@ -8345,7 +8345,7 @@ conversions the warnings @option{-Wno-int-to-pointer-cast} and
>>>> @item -Wzero-length-bounds
>>>> Warn about accesses to elements of zero-length array members that might
>>>> overlap other members of the same object. Declaring interior zero-length
>>>> -arrays is discouraged because accesses to them are undefined. See
>>>> +arrays is discouraged because accesses to them are undefined.
>>>> @xref{Zero Length}.
>>>
>>> I'm not a native speaker, but wouldn't it be better to talk about singular access, i.e. s/accesses/access/ in both cases?
>>>
>>> thanks,
>>
>> As a native speaker it does not feel ergonomic to use 'accesses' in this
>> context but it also does not feel objectively wrong. I'm happy to
>> provide a follow-up patch if you feel strongly about it.
>
> I'd prefer the singular but defer to the documentation maintainers.
I think the patch is fine as posted, with "accesses/are". Sean, do you
need somebody to push this for you?
-Sandra
next prev parent reply other threads:[~2023-03-12 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f82b00e1-1263-79cc-78d8-887a5580026f@seanbright.com>
2023-03-11 17:33 ` Sean Bright
2023-03-11 23:39 ` Bernhard Reutner-Fischer
2023-03-12 2:47 ` Sean Bright
2023-03-12 8:12 ` Bernhard Reutner-Fischer
2023-03-12 19:32 ` Sandra Loosemore [this message]
2023-03-13 13:40 ` Sean Bright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99de2404-430d-954a-7f0c-63c98238aed1@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
--cc=sean@seanbright.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).