Re: [PATCH] [arm] adjust tests for quotes around +cdecp<N>

[Christophe Lyon <christophe.lyon@arm.com>]

On 2/22/23 13:38, Alexandre Oliva wrote:
> Hello, Christophe,
> 
> On Feb 20, 2023, Christophe Lyon <christophe.lyon@arm.com> wrote:
> 
>> On 2/17/23 08:17, Alexandre Oliva via Gcc-patches wrote:
>>>
>>> Back when quotes were added around "+cdecp<N>" in the "coproc must be
>>> a constant immediate" error in arm-builtins.cc, tests for that message
>>> lagged behind.  Fixed thusly.
>>>
>>> Regstrapped on x86_64-linux-gnu.
>>> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk).  Ok to install?
> 
>> It seems this changed with r12-6553-gc3782843badbf3, right?
> 
> Yup.
> 
>> I see this commit added quotes in several others places: are the two
>> tests you fix the only ones impacted?
> 
> https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612176.html in
> asm-flag-4.c also fixed fallout from that patch, I realize now, but that
> was all that came up in our testing.
> 
> I didn't start from that patch, I was just going through test results,
> investigating the failures and fixing them or at least annotating the
> failures as expected.
> 
> It is conceivable that other quoted strings appear in tests that are
> skipped by all of the target variants that we test.  Indeed, I went
> through some arm-*-eabi variants not long ago, and these didn't come up.
> So, in case you're wondering whether to look for the other strings in
> the tests or somesuch, please don't assume I've already done so.
> 
OK thanks for the clarification.

(and for the other cleanup patches!)

Christophe