From: Alexandre Oliva <oliva@adacore.com>
To: Christophe Lyon <christophe.lyon@arm.com>
Cc: gcc-patches@gcc.gnu.org, nickc@redhat.com, richard.earnshaw@arm.com
Subject: Re: [PATCH] [arm] adjust tests for quotes around +cdecp<N>
Date: Wed, 22 Feb 2023 09:38:23 -0300 [thread overview]
Message-ID: <or4jrd3mf4.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <34f5c89d-9298-2ed2-95b5-faee25da0b72@arm.com> (Christophe Lyon's message of "Mon, 20 Feb 2023 14:15:15 +0100")
Hello, Christophe,
On Feb 20, 2023, Christophe Lyon <christophe.lyon@arm.com> wrote:
> On 2/17/23 08:17, Alexandre Oliva via Gcc-patches wrote:
>>
>> Back when quotes were added around "+cdecp<N>" in the "coproc must be
>> a constant immediate" error in arm-builtins.cc, tests for that message
>> lagged behind. Fixed thusly.
>>
>> Regstrapped on x86_64-linux-gnu.
>> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install?
> It seems this changed with r12-6553-gc3782843badbf3, right?
Yup.
> I see this commit added quotes in several others places: are the two
> tests you fix the only ones impacted?
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612176.html in
asm-flag-4.c also fixed fallout from that patch, I realize now, but that
was all that came up in our testing.
I didn't start from that patch, I was just going through test results,
investigating the failures and fixing them or at least annotating the
failures as expected.
It is conceivable that other quoted strings appear in tests that are
skipped by all of the target variants that we test. Indeed, I went
through some arm-*-eabi variants not long ago, and these didn't come up.
So, in case you're wondering whether to look for the other strings in
the tests or somesuch, please don't assume I've already done so.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
next prev parent reply other threads:[~2023-02-22 12:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 7:17 Alexandre Oliva
2023-02-20 13:15 ` Christophe Lyon
2023-02-22 12:38 ` Alexandre Oliva [this message]
2023-02-22 13:12 ` Christophe Lyon
2023-03-03 8:24 ` Alexandre Oliva
2023-03-03 8:56 ` Christophe Lyon
2023-03-03 9:20 ` Kyrylo Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=or4jrd3mf4.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=christophe.lyon@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nickc@redhat.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).