Re: [Patch : H8300] Bug fix for bit insn and minor tweaks to insns

["H.J. Lu" <hjl.tools@gmail.com>]

On Mon, Jun 13, 2011 at 2:40 AM, Kaushik Phatak
<Kaushik.Phatak@kpitcummins.com> wrote:
> Hi Jeff,
> Thanks for the quick review.
>
>>> the right test is rtx_equal_p(operands[0], operands[1])
> Committed with above changes to the bsetqi_msx, bclrqi_msx and bnotqi_msx patterns.
>

Commit is incorrect.  Testsuite ChangeLog entries should be in
testsuite/ChangeLog.
You have duplicated lines in gcc.dg/h8300-bit-insn-ice2.c and filename
is ChangeLog
is incorrect.  I checked in this fix.

-- 
H.J.
---
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 174986)
+++ ChangeLog	(working copy)
@@ -4,7 +4,6 @@
 	condition to disallow non-identical memory locations.
 	(*andqi3_2, andqi3_1, iorqi3_1, xorqi3_1): Reorder insn to give
 	preference to bit manipulation instructions.
-	* gcc.dg/h8300-bit-insn-ice2.2: New testcase.

 2011-06-13  Jan Hubicka  <jh@suse.cz>

Index: testsuite/gcc.dg/h8300-bit-insn-ice2.c
===================================================================
--- testsuite/gcc.dg/h8300-bit-insn-ice2.c	(revision 174986)
+++ testsuite/gcc.dg/h8300-bit-insn-ice2.c	(working copy)
@@ -13,18 +13,3 @@ main (void)
   MSTPCRA = MSTPCRA2 | ~0xFE;
   return 0;
 }
-/* { dg-skip-if "" { "h8300*-*-*" } "*" "-msx*" }  */
-/* { dg-options "-O2" } */
-/* ICE for bit instruction generation using 16-bit const */
-
-#define MSTPCRA (*(volatile unsigned char*)0xFFFFC9)
-#define MSTPCRA2 (*(volatile unsigned char*)0xFFFDC8)
-
-int
-main (void)
-{
-  MSTPCRA = MSTPCRA2 & ~0x01;
-  MSTPCRA = MSTPCRA2 ^ ~0xFE;
-  MSTPCRA = MSTPCRA2 | ~0xFE;
-  return 0;
-}
Index: testsuite/ChangeLog
===================================================================
--- testsuite/ChangeLog	(revision 174986)
+++ testsuite/ChangeLog	(working copy)
@@ -1,3 +1,11 @@
+2011-06-13  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* gcc.dg/h8300-bit-insn-ice2.c: Remove duplicated lines.
+
+2011-06-13  Kaushik Phatak <kaushik.phatak@kpitcummins.com>
+
+	* gcc.dg/h8300-bit-insn-ice2.c: New testcase.
+
 2011-06-13  Thomas Koenig  <tkoenig@gcc.gnu.org>

 	* gfortran.dg/trim_optimize_8.f90:  New test case.