From: Qing Zhao <qing.zhao@oracle.com>
To: Joseph Myers <josmyers@redhat.com>
Cc: Richard Biener <richard.guenther@gmail.com>,
"uecker@tugraz.at" <uecker@tugraz.at>,
Siddhesh Poyarekar <siddhesh@gotplt.org>,
Kees Cook <keescook@chromium.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [RFC][PATCH v1 1/4] Documentation change
Date: Tue, 23 Apr 2024 19:21:55 +0000 [thread overview]
Message-ID: <BB637AD3-3583-49B9-8EB4-75F4F7C43CC0@oracle.com> (raw)
In-Reply-To: <e956eae3-6969-91ef-4a97-d83a49678882@redhat.com>
> On Apr 23, 2024, at 15:03, Joseph Myers <josmyers@redhat.com> wrote:
>
> On Tue, 23 Apr 2024, Qing Zhao wrote:
>
>> However, I am not very confident on the wording of the doc, is the
>> current wording good enough for this? Or do you have any suggestion on
>> how to make it better?
>
> I'm not convinced the statement about size (in relation to a structure
> with the member omitted) is useful for unions the way it is for
> structures. The structure with the member omitted is a relevant concept
> for thinking about a structure with a flexible array member (the flexible
> array member essentially goes after that structure); it's much less
> relevant for thinking about a union with a flexible array member.
Okay, then I will delete that statement about size.
>
> (The statement that the size is zero when all members are flexible array
> members still seems a useful one to make.)
And only keep the size is zero when all members are flexible array members.
Thanks.
Qing
>
> --
> Joseph S. Myers
> josmyers@redhat.com
>
next prev parent reply other threads:[~2024-04-23 19:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 18:43 [RFC][PATCH v1 0/4] Allow flexible array members in unions and alone in structures [PR53548] Qing Zhao
2024-04-19 18:43 ` [RFC][PATCH v1 1/4] Documentation change Qing Zhao
2024-04-19 20:54 ` Tom Tromey
2024-04-22 13:28 ` Qing Zhao
2024-04-23 18:04 ` Joseph Myers
2024-04-23 18:21 ` Qing Zhao
2024-04-23 19:03 ` Joseph Myers
2024-04-23 19:21 ` Qing Zhao [this message]
2024-04-19 18:43 ` [RFC][PATCH v1 2/4] C and C++ FE changes to support flexible array members in unions and alone in structures Qing Zhao
2024-04-23 19:51 ` Joseph Myers
2024-04-23 19:58 ` Qing Zhao
2024-04-19 18:43 ` [RFC][PATCH v1 3/4] Add testing cases for " Qing Zhao
2024-04-23 18:53 ` Joseph Myers
2024-04-23 19:30 ` Qing Zhao
2024-04-19 18:43 ` [RFC][PATCH v1 4/4] Adjust testcases for flexible array member in union and alone in structure extension Qing Zhao
2024-04-19 21:55 ` [RFC][PATCH v1 0/4] Allow flexible array members in unions and alone in structures [PR53548] Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BB637AD3-3583-49B9-8EB4-75F4F7C43CC0@oracle.com \
--to=qing.zhao@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=josmyers@redhat.com \
--cc=keescook@chromium.org \
--cc=richard.guenther@gmail.com \
--cc=siddhesh@gotplt.org \
--cc=uecker@tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).