From: Richard Biener <richard.guenther@gmail.com>
To: Zopolis0 <creatorsmithmdt@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 16/56] gcc: Re-add TYPE_METHODS.
Date: Sat, 26 Nov 2022 08:22:12 +0100 [thread overview]
Message-ID: <BE786108-1AF7-42B6-AD04-C3C50E3CCAFB@gmail.com> (raw)
In-Reply-To: <CAEYL+X_reF-T_PA-WFH8c-=TVmODRJ0Fwh-donYC0BnG9nXkTw@mail.gmail.com>
> Am 26.11.2022 um 02:55 schrieb Zopolis0 <creatorsmithmdt@gmail.com>:
>
> Oh wait wrong patch. You talking about binfo confused me.
>
> Anyways, I re-added this because replacing Java's usage of
> TYPE_METHODS with TYPE_FIELDS even when I properly checked for
> different types of functions still broke things, so I added this as a
> stopgap.
>
> No idea what you are talking about with binfo though, I added binfo
> for the reasons you can see in the email above, nothing to do with
> TYPE_METHODS.
TYPE_METHODS uses the field used by TYPE_BINFO so the patches are related.
I fear you have to understand what the java
Frontend does to fix your problem, I certainly don’t know what it does wrong here. Re-adding a field to all types is a no-go
Richard
>
>> On Sat, Nov 26, 2022 at 11:16 AM Zopolis0 <creatorsmithmdt@gmail.com> wrote:
>>
>> Because the frontend uses TYPE_BINFO specifically. It expects a TYPE_BINFO that writes to this value, and will break with replacements. I have tried a number of alternatives, and this is what works.
>>
>> I can't use lang_1 because other frontends use it in ways that java doesn't expect and I can't create a replacement for TYPE_BINFO because then it won't have the regular checks that TYPE_BINFO has.
>>
>> I couldn't find a better solution because I'm not particularly versed with the internal workings of gcc, if you can think of a better idea feel free to let me know.
>>
>>> On Sat, 26 Nov 2022 at 07:20, Richard Biener <richard.guenther@gmail.com> wrote:
>>>
>>> On Fri, Nov 25, 2022 at 9:55 AM Zopolis0 via Gcc-patches
>>> <gcc-patches@gcc.gnu.org> wrote:
>>>>
>>>
>>> Why add this when nothing uses it and you need to re-add binfo because
>>> of this? If the frontend uses
>>> it then add it to lang_type.
next prev parent reply other threads:[~2022-11-26 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 8:40 Zopolis0
2022-11-25 20:20 ` Richard Biener
2022-11-26 0:16 ` Zopolis0
2022-11-26 1:54 ` Zopolis0
2022-11-26 7:22 ` Richard Biener [this message]
2022-11-26 7:30 ` Zopolis0
2022-11-26 7:48 ` Xi Ruoyao
2022-11-26 8:26 ` Zopolis0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE786108-1AF7-42B6-AD04-C3C50E3CCAFB@gmail.com \
--to=richard.guenther@gmail.com \
--cc=creatorsmithmdt@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).