public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Zopolis0 <creatorsmithmdt@gmail.com>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Richard Biener <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 16/56] gcc: Re-add TYPE_METHODS.
Date: Sat, 26 Nov 2022 19:26:50 +1100	[thread overview]
Message-ID: <CAEYL+X-eTaMenfiTYT2bxcGrnNb=8xyzzy=wVk1MHsV1QjfPMQ@mail.gmail.com> (raw)
In-Reply-To: <9b5cdf691510b783f42d3de6099c5bbe9b931236.camel@xry111.site>

> No.  Java was removed to reduce the maintenance burden, you can't just
> reintroduce the burden and say "hey, I don't want to pay for the burden
> so you please do it".

There were two sentences there. You appear to only have read the first one.

I just took on 6 years of that maintenance burden in 4 months while
teaching myself the gcc tree.
I can confirm with absolute certainty that the burden would have been
pitiful had java been in the tree. Many of the changes were just
idiomatic find and replaces that I had to do myself, tracking down the
commit that removed or renamed something, in some cases just silently
breaking things so I had to bisect 6 years of changes. If Java had
been in the tree, it would have introduced a pitiful additional
burden. I can think of around 5 changes that I made that would have
required something more than just a sed script, and even then those
were very simple changes.

I am not suggesting that I wish to shift the overall burden of
maintenance away from myself, rather that it would be nice if I did
not have to track down breaking commits every 3 months, when the
author could have very easily included Java in the changes if it was
in the tree.

> And we are in stage 3 now so it's not possible to merge 50+ patches
> (completely not reviewed in stage 1) until GCC 14 stage 1 opens.

On a lighter note, this is fair. I was hoping to make the stage 1
window, but with 2 front-ends already in contention I thought my odds
of making it in regardless were poor, and I just didn't have the time
to fix the last issues.

I've sent these patches now so they can get reviewed now, so that they
aren't waiting in review limbo when merging is open again.

      reply	other threads:[~2022-11-26  8:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25  8:40 Zopolis0
2022-11-25 20:20 ` Richard Biener
2022-11-26  0:16   ` Zopolis0
2022-11-26  1:54     ` Zopolis0
2022-11-26  7:22       ` Richard Biener
2022-11-26  7:30         ` Zopolis0
2022-11-26  7:48           ` Xi Ruoyao
2022-11-26  8:26             ` Zopolis0 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEYL+X-eTaMenfiTYT2bxcGrnNb=8xyzzy=wVk1MHsV1QjfPMQ@mail.gmail.com' \
    --to=creatorsmithmdt@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).