From: Andrew Pinski <pinskia@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE
Date: Sun, 22 Oct 2023 09:09:50 -0700 [thread overview]
Message-ID: <CA+=Sn1=h80nBHZHHX9YZrLZ-kd6H3twaiDNfUDOzNKVK_C8exQ@mail.gmail.com> (raw)
In-Reply-To: <87zg0bhzep.fsf@oldenburg.str.redhat.com>
On Sun, Oct 22, 2023 at 12:47 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> Current glibc headers only declare fputs_unlocked for _GNU_SOURCE.
> Defining the macro avoids an implicit function declaration.
This does not help targets that don't use glibc though.
Note for builtins testsuite there is a lib-fputs.c file which will
define a fputs_unlock which is how it will link even if the libc does
not define a fputs_unlock.
Thanks,
Andrew Pinski
>
> gcc/testsuite/
>
> * gcc.c-torture/execute/builtins/fputs.c (_GNU_SOURCE):
> Define.
>
> ---
> gcc/testsuite/gcc.c-torture/execute/builtins/fputs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.c-torture/execute/builtins/fputs.c b/gcc/testsuite/gcc.c-torture/execute/builtins/fputs.c
> index 93fa9736449..13e30724355 100644
> --- a/gcc/testsuite/gcc.c-torture/execute/builtins/fputs.c
> +++ b/gcc/testsuite/gcc.c-torture/execute/builtins/fputs.c
> @@ -5,6 +5,7 @@
>
> Written by Kaveh R. Ghazi, 10/30/2000. */
>
> +#define _GNU_SOURCE /* For fputs_unlocked. */
> #include <stdio.h>
> extern void abort(void);
>
>
next prev parent reply other threads:[~2023-10-22 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 7:47 Florian Weimer
2023-10-22 13:44 ` Jeff Law
2023-10-22 16:09 ` Andrew Pinski [this message]
2023-10-22 19:45 ` Jeff Law
2023-10-22 20:02 ` rep.dot.nop
2023-10-23 5:57 ` Eric Gallager
2023-10-23 8:39 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1=h80nBHZHHX9YZrLZ-kd6H3twaiDNfUDOzNKVK_C8exQ@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).