[PATCH 0/1] RISC-V: Imply 'Zicsr' from 'Zcmt'

[PATCH 0/1] RISC-V: Imply 'Zicsr' from 'Zcmt'

[Tsukasa OI]

This is a subset of my patch set
"RISC-V: Add stub support for existing extensions"
<https://gcc.gnu.org/pipermail/gcc-patches/2023-August/628643.html>
for faster review.

Since 'Zcmt' requires 'Zicsr' (and this is a bug unlike other changes in
the patch set above), this small patch is splitted.

Thanks,
Tsukasa




Tsukasa OI (1):
  RISC-V: Imply 'Zicsr' from 'Zcmt'

 gcc/common/config/riscv/riscv-common.cc | 1 +
 1 file changed, 1 insertion(+)


base-commit: 818cc9f2d2f3dbbd4004ff85d3125d92d1e430c9
-- 
2.42.0

[PATCH 1/1] RISC-V: Imply 'Zicsr' from 'Zcmt'

[Tsukasa OI]

From: Tsukasa OI <research_trasio@irq.a4lg.com>

As the specification states, the 'Zcmt' extension depends on the 'Zca' and
'Zicsr' extensions.  This commit reflects this implication.

gcc/ChangeLog:

	* common/config/riscv/riscv-common.cc
	(riscv_implied_info): Add implication from 'Zcmt' to 'Zicsr'.
---
 gcc/common/config/riscv/riscv-common.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc
index a5b62cda3a09..1315c8a745ec 100644
--- a/gcc/common/config/riscv/riscv-common.cc
+++ b/gcc/common/config/riscv/riscv-common.cc
@@ -142,6 +142,7 @@ static const riscv_implied_info_t riscv_implied_info[] =
   {"zcb",  "zca"},
   {"zcmp", "zca"},
   {"zcmt", "zca"},
+  {"zcmt", "zicsr"},
 
   {NULL, NULL}
 };
-- 
2.42.0

Re: [PATCH 1/1] RISC-V: Imply 'Zicsr' from 'Zcmt'

[Kito Cheng]

LGTM, did you have commit access for GCC repo? you should obtain it if
you don't have it yet, I think you are already an important member of
the RISC-V GNU toolchain community :)

https://gcc.gnu.org/gitwrite.html#authenticated , and you can add me
to the cc list as your sponsor.



On Tue, Aug 29, 2023 at 11:42 AM Tsukasa OI via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> From: Tsukasa OI <research_trasio@irq.a4lg.com>
>
> As the specification states, the 'Zcmt' extension depends on the 'Zca' and
> 'Zicsr' extensions.  This commit reflects this implication.
>
> gcc/ChangeLog:
>
>         * common/config/riscv/riscv-common.cc
>         (riscv_implied_info): Add implication from 'Zcmt' to 'Zicsr'.
> ---
>  gcc/common/config/riscv/riscv-common.cc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc
> index a5b62cda3a09..1315c8a745ec 100644
> --- a/gcc/common/config/riscv/riscv-common.cc
> +++ b/gcc/common/config/riscv/riscv-common.cc
> @@ -142,6 +142,7 @@ static const riscv_implied_info_t riscv_implied_info[] =
>    {"zcb",  "zca"},
>    {"zcmp", "zca"},
>    {"zcmt", "zca"},
> +  {"zcmt", "zicsr"},
>
>    {NULL, NULL}
>  };
> --
> 2.42.0
>

Re: [PATCH 1/1] RISC-V: Imply 'Zicsr' from 'Zcmt'

[Tsukasa OI]

On 2023/08/29 17:42, Kito Cheng wrote:
> LGTM, did you have commit access for GCC repo? you should obtain it if
> you don't have it yet, I think you are already an important member of
> the RISC-V GNU toolchain community :)

Not yet (only Binutils/GDB).  Jeff is mainly merging my changes to the
trunk so far.

Thanks for mentioning and sponsoring me for write access to GCC.  I
truly appreciate that mentioning me as an important member and write
access to the GCC repository will be also helpful.

I'll contact GCC overseers later.

Sincerely,
Tsukasa

> 
> https://gcc.gnu.org/gitwrite.html#authenticated , and you can add me
> to the cc list as your sponsor.
> 
> 
> 
> On Tue, Aug 29, 2023 at 11:42 AM Tsukasa OI via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>>
>> From: Tsukasa OI <research_trasio@irq.a4lg.com>
>>
>> As the specification states, the 'Zcmt' extension depends on the 'Zca' and
>> 'Zicsr' extensions.  This commit reflects this implication.
>>
>> gcc/ChangeLog:
>>
>>         * common/config/riscv/riscv-common.cc
>>         (riscv_implied_info): Add implication from 'Zcmt' to 'Zicsr'.
>> ---
>>  gcc/common/config/riscv/riscv-common.cc | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc
>> index a5b62cda3a09..1315c8a745ec 100644
>> --- a/gcc/common/config/riscv/riscv-common.cc
>> +++ b/gcc/common/config/riscv/riscv-common.cc
>> @@ -142,6 +142,7 @@ static const riscv_implied_info_t riscv_implied_info[] =
>>    {"zcb",  "zca"},
>>    {"zcmp", "zca"},
>>    {"zcmt", "zca"},
>> +  {"zcmt", "zicsr"},
>>
>>    {NULL, NULL}
>>  };
>> --
>> 2.42.0
>>
> 

Re: [PATCH 1/1] RISC-V: Imply 'Zicsr' from 'Zcmt'

[Kito Cheng]

Hi Tsukasa:

I guess you might did something wrong during commit this patch and
"RISC-V: Add stub support for existing extensions"

https://github.com/gcc-mirror/gcc/commit/f30d6a48635b5b180e46c51138d0938d33abd942

On Tue, Aug 29, 2023 at 4:55 PM Tsukasa OI via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On 2023/08/29 17:42, Kito Cheng wrote:
> > LGTM, did you have commit access for GCC repo? you should obtain it if
> > you don't have it yet, I think you are already an important member of
> > the RISC-V GNU toolchain community :)
>
> Not yet (only Binutils/GDB).  Jeff is mainly merging my changes to the
> trunk so far.
>
> Thanks for mentioning and sponsoring me for write access to GCC.  I
> truly appreciate that mentioning me as an important member and write
> access to the GCC repository will be also helpful.
>
> I'll contact GCC overseers later.
>
> Sincerely,
> Tsukasa
>
> >
> > https://gcc.gnu.org/gitwrite.html#authenticated , and you can add me
> > to the cc list as your sponsor.
> >
> >
> >
> > On Tue, Aug 29, 2023 at 11:42 AM Tsukasa OI via Gcc-patches
> > <gcc-patches@gcc.gnu.org> wrote:
> >>
> >> From: Tsukasa OI <research_trasio@irq.a4lg.com>
> >>
> >> As the specification states, the 'Zcmt' extension depends on the 'Zca' and
> >> 'Zicsr' extensions.  This commit reflects this implication.
> >>
> >> gcc/ChangeLog:
> >>
> >>         * common/config/riscv/riscv-common.cc
> >>         (riscv_implied_info): Add implication from 'Zcmt' to 'Zicsr'.
> >> ---
> >>  gcc/common/config/riscv/riscv-common.cc | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc
> >> index a5b62cda3a09..1315c8a745ec 100644
> >> --- a/gcc/common/config/riscv/riscv-common.cc
> >> +++ b/gcc/common/config/riscv/riscv-common.cc
> >> @@ -142,6 +142,7 @@ static const riscv_implied_info_t riscv_implied_info[] =
> >>    {"zcb",  "zca"},
> >>    {"zcmp", "zca"},
> >>    {"zcmt", "zca"},
> >> +  {"zcmt", "zicsr"},
> >>
> >>    {NULL, NULL}
> >>  };
> >> --
> >> 2.42.0
> >>
> >

Re: [PATCH 1/1] RISC-V: Imply 'Zicsr' from 'Zcmt'

[Tsukasa OI]

On 2023/08/31 18:10, Kito Cheng wrote:
> Hi Tsukasa:
> 
> I guess you might did something wrong during commit this patch and
> "RISC-V: Add stub support for existing extensions"
> 
> https://github.com/gcc-mirror/gcc/commit/f30d6a48635b5b180e46c51138d0938d33abd942
> 

It's fine.  That patch was a part of "RISC-V: Add stub support for
existing extensions" (the only intent for subset submission was faster
review but the bigger one is accepted earlier than I expected).

Tsukasa

Re: [PATCH 1/1] RISC-V: Imply 'Zicsr' from 'Zcmt'

[Kito Cheng]

Ok, I just went through the patchlist and found this patch seems
not committed yet, anyway I will mark this as commit now :)


On Thu, Aug 31, 2023 at 5:14 PM Tsukasa OI via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On 2023/08/31 18:10, Kito Cheng wrote:
> > Hi Tsukasa:
> >
> > I guess you might did something wrong during commit this patch and
> > "RISC-V: Add stub support for existing extensions"
> >
> > https://github.com/gcc-mirror/gcc/commit/f30d6a48635b5b180e46c51138d0938d33abd942
> >
>
> It's fine.  That patch was a part of "RISC-V: Add stub support for
> existing extensions" (the only intent for subset submission was faster
> review but the bigger one is accepted earlier than I expected).
>
> Tsukasa