Re: Re: [PATCH] RISC-V: Allow VMS{Compare} (V1, V1) shortcut optimization

[Kito Cheng <kito.cheng@gmail.com>]

I got a bunch of new fails including ICE for gcc testsuite, and some
cases are hanging there, could you take a look?

$ riscv64-unknown-linux-gnu-gcc
gcc.target/riscv/rvv/vsetvl/avl_single-92.c -O2 -march=rv32gcv
-mabi=ilp32
during RTL pass: expand
/scratch1/kitoc/riscv-gnu-workspace/riscv-gnu-toolchain-trunk/gcc/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/avl_single-92.c:
In function 'f':
/scratch1/kitoc/riscv-gnu-workspace/riscv-gnu-toolchain-trunk/gcc/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/avl_single-92.c:8:13:
internal compiler error: in maybe_gen_insn, at optabs.cc:8102
    8 |   vbool64_t mask = *(vbool64_t*) (in + 1000000);
      |             ^~~~
0x130d278 maybe_gen_insn(insn_code, unsigned int, expand_operand*)
        ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/optabs.cc:8102


On Fri, Apr 21, 2023 at 5:47 PM Li, Pan2 via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Kindly ping for the PATCH v2. Just FYI there will be some underlying investigation based on this PATCH like VMSEQ.
>
> Pan
>
> -----Original Message-----
> From: Li, Pan2
> Sent: Wednesday, April 19, 2023 7:27 PM
> To: 'Kito Cheng' <kito.cheng@gmail.com>; 'juzhe.zhong@rivai.ai' <juzhe.zhong@rivai.ai>
> Cc: 'gcc-patches' <gcc-patches@gcc.gnu.org>; 'Kito.cheng' <kito.cheng@sifive.com>; Wang, Yanzhang <yanzhang.wang@intel.com>
> Subject: RE: Re: [PATCH] RISC-V: Allow VMS{Compare} (V1, V1) shortcut optimization
>
> Update the Patch v2 for more detail information for clarification. Please help to review continuously.
>
> https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616175.html
>
> Pan
>
> -----Original Message-----
> From: Li, Pan2
> Sent: Wednesday, April 19, 2023 6:33 PM
> To: Kito Cheng <kito.cheng@gmail.com>; juzhe.zhong@rivai.ai
> Cc: gcc-patches <gcc-patches@gcc.gnu.org>; Kito.cheng <kito.cheng@sifive.com>; Wang, Yanzhang <yanzhang.wang@intel.com>
> Subject: RE: Re: [PATCH] RISC-V: Allow VMS{Compare} (V1, V1) shortcut optimization
>
> Sure thing.
>
> For Changlog, I consider it was generated automatically in previous. LOL.
>
> Pan
>
> -----Original Message-----
> From: Kito Cheng <kito.cheng@gmail.com>
> Sent: Wednesday, April 19, 2023 5:46 PM
> To: juzhe.zhong@rivai.ai
> Cc: Li, Pan2 <pan2.li@intel.com>; gcc-patches <gcc-patches@gcc.gnu.org>; Kito.cheng <kito.cheng@sifive.com>; Wang, Yanzhang <yanzhang.wang@intel.com>
> Subject: Re: Re: [PATCH] RISC-V: Allow VMS{Compare} (V1, V1) shortcut optimization
>
> HI JuZhe:
>
> Thanks for explaining!
>
>
> Hi Pan:
>
> I think that would be helpful if JuZhe's explaining that could be written into the commit log.
>
>
> > gcc/ChangeLog:
> >
> >        * config/riscv/riscv-v.cc (emit_pred_op):
> >        * config/riscv/riscv-vector-builtins-bases.cc:
> >        * config/riscv/vector.md:
>
> And don't forgot write some thing in ChangeLog...:P