From: Kito Cheng <kito.cheng@gmail.com>
To: "Maciej W. Rozycki" <macro@embecosm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Andrew Waterman <andrew@sifive.com>
Subject: Re: [PATCH] RISC-V/testsuite: Restrict remaining `fmin'/`fmax' tests to hard float
Date: Thu, 11 Aug 2022 10:38:40 +0800 [thread overview]
Message-ID: <CA+yXCZDWto6u7uatPOyugs4VtWwwN54p8RXO_FzRBZfTrPeWdg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.2207282043000.10833@tpp.orcam.me.uk>
LGTM, thanks :)
On Fri, Jul 29, 2022 at 3:52 AM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> Complement commit 7915f6551343 ("RISC-V/testsuite: constraint some of
> tests to hard_float") and also restrict the remaining `fmin'/`fmax'
> tests to hard-float test configurations.
>
> gcc/testsuite/
> * gcc.target/riscv/fmax-snan.c: Add `dg-require-effective-target
> hard_float'.
> * gcc.target/riscv/fmaxf-snan.c: Likewise.
> * gcc.target/riscv/fmin-snan.c: Likewise.
> * gcc.target/riscv/fminf-snan.c: Likewise.
> ---
> gcc/testsuite/gcc.target/riscv/fmax-snan.c | 1 +
> gcc/testsuite/gcc.target/riscv/fmaxf-snan.c | 1 +
> gcc/testsuite/gcc.target/riscv/fmin-snan.c | 1 +
> gcc/testsuite/gcc.target/riscv/fminf-snan.c | 1 +
> 4 files changed, 4 insertions(+)
>
> gcc-riscv-fmin-fmax-test-hard-float.diff
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
> double
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
> float
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
> double
> Index: gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
> float
next prev parent reply other threads:[~2022-08-11 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 19:51 Maciej W. Rozycki
2022-08-11 2:38 ` Kito Cheng [this message]
2022-08-17 22:24 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+yXCZDWto6u7uatPOyugs4VtWwwN54p8RXO_FzRBZfTrPeWdg@mail.gmail.com \
--to=kito.cheng@gmail.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=macro@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).