* [PATCH] RISC-V/testsuite: Restrict remaining `fmin'/`fmax' tests to hard float
@ 2022-07-28 19:51 Maciej W. Rozycki
2022-08-11 2:38 ` Kito Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Maciej W. Rozycki @ 2022-07-28 19:51 UTC (permalink / raw)
To: gcc-patches; +Cc: Andrew Waterman, Jim Wilson, Kito Cheng, Palmer Dabbelt
Complement commit 7915f6551343 ("RISC-V/testsuite: constraint some of
tests to hard_float") and also restrict the remaining `fmin'/`fmax'
tests to hard-float test configurations.
gcc/testsuite/
* gcc.target/riscv/fmax-snan.c: Add `dg-require-effective-target
hard_float'.
* gcc.target/riscv/fmaxf-snan.c: Likewise.
* gcc.target/riscv/fmin-snan.c: Likewise.
* gcc.target/riscv/fminf-snan.c: Likewise.
---
gcc/testsuite/gcc.target/riscv/fmax-snan.c | 1 +
gcc/testsuite/gcc.target/riscv/fmaxf-snan.c | 1 +
gcc/testsuite/gcc.target/riscv/fmin-snan.c | 1 +
gcc/testsuite/gcc.target/riscv/fminf-snan.c | 1 +
4 files changed, 4 insertions(+)
gcc-riscv-fmin-fmax-test-hard-float.diff
Index: gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
===================================================================
--- gcc.orig/gcc/testsuite/gcc.target/riscv/fmax-snan.c
+++ gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target hard_float } */
/* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
double
Index: gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
===================================================================
--- gcc.orig/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
+++ gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target hard_float } */
/* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
float
Index: gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
===================================================================
--- gcc.orig/gcc/testsuite/gcc.target/riscv/fmin-snan.c
+++ gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target hard_float } */
/* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
double
Index: gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
===================================================================
--- gcc.orig/gcc/testsuite/gcc.target/riscv/fminf-snan.c
+++ gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target hard_float } */
/* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
float
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V/testsuite: Restrict remaining `fmin'/`fmax' tests to hard float
2022-07-28 19:51 [PATCH] RISC-V/testsuite: Restrict remaining `fmin'/`fmax' tests to hard float Maciej W. Rozycki
@ 2022-08-11 2:38 ` Kito Cheng
2022-08-17 22:24 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Kito Cheng @ 2022-08-11 2:38 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: GCC Patches, Andrew Waterman
LGTM, thanks :)
On Fri, Jul 29, 2022 at 3:52 AM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> Complement commit 7915f6551343 ("RISC-V/testsuite: constraint some of
> tests to hard_float") and also restrict the remaining `fmin'/`fmax'
> tests to hard-float test configurations.
>
> gcc/testsuite/
> * gcc.target/riscv/fmax-snan.c: Add `dg-require-effective-target
> hard_float'.
> * gcc.target/riscv/fmaxf-snan.c: Likewise.
> * gcc.target/riscv/fmin-snan.c: Likewise.
> * gcc.target/riscv/fminf-snan.c: Likewise.
> ---
> gcc/testsuite/gcc.target/riscv/fmax-snan.c | 1 +
> gcc/testsuite/gcc.target/riscv/fmaxf-snan.c | 1 +
> gcc/testsuite/gcc.target/riscv/fmin-snan.c | 1 +
> gcc/testsuite/gcc.target/riscv/fminf-snan.c | 1 +
> 4 files changed, 4 insertions(+)
>
> gcc-riscv-fmin-fmax-test-hard-float.diff
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
> double
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
> float
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
> double
> Index: gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } */
>
> float
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V/testsuite: Restrict remaining `fmin'/`fmax' tests to hard float
2022-08-11 2:38 ` Kito Cheng
@ 2022-08-17 22:24 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2022-08-17 22:24 UTC (permalink / raw)
To: Kito Cheng; +Cc: GCC Patches, Andrew Waterman
On Thu, 11 Aug 2022, Kito Cheng wrote:
> LGTM, thanks :)
I have committed this change now. Thank you for your review.
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-17 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 19:51 [PATCH] RISC-V/testsuite: Restrict remaining `fmin'/`fmax' tests to hard float Maciej W. Rozycki
2022-08-11 2:38 ` Kito Cheng
2022-08-17 22:24 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).