Re: [PATCH] RISC-V: costs: handle BSWAP

[Philipp Tomsich <philipp.tomsich@vrull.eu>]

On Wed, 9 Nov 2022 at 05:43, Andrew Pinski <pinskia@gmail.com> wrote:
>
> On Tue, Nov 8, 2022 at 7:16 PM Palmer Dabbelt <palmer@rivosinc.com> wrote:
> >
> > On Tue, 08 Nov 2022 18:57:26 PST (-0800), jeffreyalaw@gmail.com wrote:
> > >
> > > On 11/8/22 12:54, Philipp Tomsich wrote:
> > >> The BSWAP operation is not handled in rtx_costs. Add it.
> > >>
> > >> With Zbb, BSWAP for XLEN is a single instruction; for smaller modes,
> > >> it will expand into two.
> > >>
> > >> gcc/ChangeLog:
> > >>
> > >>          * config/riscv/riscv.c (rtx_costs): Add BSWAP.
> > >
> > > OK.
> >
> > It's riscv_rtx_costs.
> >
> > (I don't usually read ChangeLog entries that closely, just happened to
> > stumble on it when poking around.)
>
> Using contrib/git-commit-mklog.py can help here to make sure you
> always get the correct format for the changelog and it does a decent
> job of figuring out function names too.
> You can also use contrib/gcc-git-customization.sh to install it such
> that you can use it when doing git commits.
> After invoking that inside the GCC git; you can just do "git
> gcc-commit-mklog ...." Where .... would be what you normally put for
> "git commit" (but as if in the toplevel directory).

We always pass them through contrib/mklog,py (or git-commit-mklog.py,
which invokes it) anyway, but (as the ".c" in the filename indicates)
this one hasn't been refreshed in over a year's time.
Don't worry, this will need to get adjusted again once I merge it (as
the commit hooks won't let it pass).

Philipp.