From: Uros Bizjak <ubizjak@gmail.com>
To: "Joshi, Tejas Sanjay" <TejasSanjay.Joshi@amd.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Kumar, Venkataramanan" <Venkataramanan.Kumar@amd.com>,
"honza.hubicka@gmail.com" <honza.hubicka@gmail.com>
Subject: Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU
Date: Sun, 16 Oct 2022 19:48:49 +0200 [thread overview]
Message-ID: <CAFULd4Z9FggfETr2hdb=Mi0MwzJY+86Lei-=AjW6ThmrTvGdZA@mail.gmail.com> (raw)
In-Reply-To: <DM6PR12MB4795EB24ADE00211DE7155CBE3259@DM6PR12MB4795.namprd12.prod.outlook.com>
On Thu, Oct 13, 2022 at 5:33 PM Joshi, Tejas Sanjay
<TejasSanjay.Joshi@amd.com> wrote:
>
> [Public]
>
> Hi all,
>
> PFA, the patch that enables support for the next generation AMD Zen4 CPU via -march=znver4.
> This is a basic enablement patch and as of now the costings, tunings are kept same as znver3.
>
> Good for trunk?
2022-09-28 Tejas Joshi <TejasSanjay.Joshi@amd.com>
gcc/ChangeLog:
* common/config/i386/cpuinfo.h (get_amd_cpu): Recognize znver4.
* common/config/i386/i386-common.cc (processor_names): Add znver4.
(processor_alias_table): Add znver4 and modularize old znvers.
* common/config/i386/i386-cpuinfo.h (processor_subtypes):
AMDFAM19H_ZNVER4.
* config.gcc (x86_64-*-* |...): Likewise.
* config/i386/driver-i386.cc (host_detect_local_cpu): Let
-march=native recognize znver4 cpus.
* config/i386/i386-c.cc (ix86_target_macros_internal): Add znver4.
* config/i386/i386-options.cc (m_ZNVER4): New definition.
(m_ZNVER): Include m_ZNVER4.
(processor_cost_table): Add znver4.
* config/i386/i386.cc (ix86_reassociation_width): Likewise.
* gcc/config/i386/i386.h (processor_type): Add PROCESSOR_ZNVER4.
(PTA_ZNVER1): New definition.
(PTA_ZNVER2): Likewise.
(PTA_ZNVER3): Likewise.
(PTA_ZNVER4): Likewise.
* config/i386/i386.md (define_attr "cpu"): Add znver4.
* config/i386/x86-tune-costs.h (znver4_cost): New definition.
* config/i386/x86-tune-sched.cc (ix86_issue_rate): Add znver4.
(ix86_adjust_cost): Likewise.
* config/i386/znver1.md: Add new reservations for znver4.
* doc/extend.texi: Add details about znver4.
* doc/invoke.texi: Likewise.
gcc/testsuite/ChangeLog:
* gcc.target/i386/funcspec-56.inc: Handle new march.
* g++.target/i386/mv29.C: Likewise.
Although I didn't check all the details of the new scheduler model,
the patch LGTM for mainline.
BTW: Perhaps znver1.md is not the right filename anymore, since it
hosts all four Zen schedulers.
Thanks,
Uros.
next prev parent reply other threads:[~2022-10-16 17:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 15:32 Joshi, Tejas Sanjay
2022-10-16 17:48 ` Uros Bizjak [this message]
2022-10-17 14:39 ` Joshi, Tejas Sanjay
2022-10-21 9:59 ` Kumar, Venkataramanan
2022-10-21 11:51 ` Richard Biener
2022-10-21 12:52 ` Jan Hubicka
2022-10-21 14:02 ` Joshi, Tejas Sanjay
2022-10-21 17:59 ` Joshi, Tejas Sanjay
2022-10-22 17:11 ` Jakub Jelinek
2022-10-23 14:29 ` Kumar, Venkataramanan
2022-10-24 14:26 ` Alexander Monakov
2022-10-24 14:40 ` Jan Hubička
2022-10-24 18:47 ` Alexander Monakov
2022-10-26 18:07 ` Kumar, Venkataramanan
2022-10-26 18:23 ` Alexander Monakov
2022-10-31 10:39 ` Joshi, Tejas Sanjay
2022-10-31 10:59 ` Jan Hubička
2022-11-01 12:22 ` Alexander Monakov
2022-10-25 9:17 ` Joshi, Tejas Sanjay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4Z9FggfETr2hdb=Mi0MwzJY+86Lei-=AjW6ThmrTvGdZA@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=TejasSanjay.Joshi@amd.com \
--cc=Venkataramanan.Kumar@amd.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=honza.hubicka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).