From: Jan Hubicka <firstname.lastname@example.org>
To: Richard Biener <email@example.com>
Cc: "Kumar, Venkataramanan" <Venkataramanan.Kumar@amd.com>,
"Joshi, Tejas Sanjay" <TejasSanjay.Joshi@amd.com>,
Subject: Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU
Date: Fri, 21 Oct 2022 14:52:22 +0200 [thread overview]
Message-ID: <Y1KWBuWhZC89HT9E@kam.mff.cuni.cz> (raw)
> On Fri, Oct 21, 2022 at 12:00 PM Kumar, Venkataramanan via Gcc-patches
> <firstname.lastname@example.org> wrote:
> > Hi all,
> > > -----Original Message-----
> > > From: Joshi, Tejas Sanjay <TejasSanjay.Joshi@amd.com>
> > > Sent: Monday, October 17, 2022 8:09 PM
> > > To: email@example.com
> > > Cc: Kumar, Venkataramanan <Venkataramanan.Kumar@amd.com>;
> > > firstname.lastname@example.org; Uros Bizjak <email@example.com>
> > > Subject: RE: [PATCH] [X86_64]: Enable support for next generation AMD
> > > Zen4 CPU
> > >
> > > [Public]
> > >
> > > Hi,
> > >
> > > > BTW: Perhaps znver1.md is not the right filename anymore, since it hosts
> > > all four Zen schedulers.
> > >
> > > I have renamed the file to znver.md in this revision, PFA.
> > > Thank you for the review, we will push it for trunk if we don't get any
> > > further comments.
> > I have pushed the patch on behalf of Tejas.
> This grew insn-automata.cc from 201502 lines to 639968 lines and the build
> of the automata (genautomata) to several minutes in my dev tree.
> You did something wrong. Please fix!
I think it may make sense to make the initial patch without scheduler
model update with zen3 scheduling. I can work on updating the model
which needs some benchmarking and setting up the cost tables first.
The problem here is that adding extra variants to execution core model
likely forces too many states.
In general DFA is not best model for such symmetirc and parallel
execution core (since there are way too many combinations individual
pipes may get). I was thinking of adding an option to generate
alternative model based on bitmasks, but never got around implementing
So with current infrastructure we always need to simplify a bit. Which
is also not big deal since the scheduling is not well documented
anyway and our model is not precise at all (it misses the on-chip
> > Regards,
> > Venkat.
next prev parent reply other threads:[~2022-10-21 12:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 15:32 Joshi, Tejas Sanjay
2022-10-16 17:48 ` Uros Bizjak
2022-10-17 14:39 ` Joshi, Tejas Sanjay
2022-10-21 9:59 ` Kumar, Venkataramanan
2022-10-21 11:51 ` Richard Biener
2022-10-21 12:52 ` Jan Hubicka [this message]
2022-10-21 14:02 ` Joshi, Tejas Sanjay
2022-10-21 17:59 ` Joshi, Tejas Sanjay
2022-10-22 17:11 ` Jakub Jelinek
2022-10-23 14:29 ` Kumar, Venkataramanan
2022-10-24 14:26 ` Alexander Monakov
2022-10-24 14:40 ` Jan Hubička
2022-10-24 18:47 ` Alexander Monakov
2022-10-26 18:07 ` Kumar, Venkataramanan
2022-10-26 18:23 ` Alexander Monakov
2022-10-31 10:39 ` Joshi, Tejas Sanjay
2022-10-31 10:59 ` Jan Hubička
2022-11-01 12:22 ` Alexander Monakov
2022-10-25 9:17 ` Joshi, Tejas Sanjay
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).