From: Uros Bizjak <ubizjak@gmail.com>
To: Haochen Jiang <haochen.jiang@intel.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Hongtao Liu <hongtao.liu@intel.com>
Subject: Re: [PATCH] i386: Extend cvtps2pd to memory
Date: Thu, 30 Jun 2022 08:20:03 +0200 [thread overview]
Message-ID: <CAFULd4aJ_a+zQh_L5eeAiBpiGAY8gcLuK9psQ6fXftc4k-TJig@mail.gmail.com> (raw)
In-Reply-To: <20220630055907.50030-1-haochen.jiang@intel.com>
On Thu, Jun 30, 2022 at 7:59 AM Haochen Jiang <haochen.jiang@intel.com> wrote:
>
> Hi all,
>
> This patch aims to fix the cvtps2pd insn, which should also work on
> memory operand but currently does not. After this fix, when loop == 2,
> it will eliminate movq instruction.
>
> Regtested on x86_64-pc-linux-gnu. Ok for trunk?
>
> BRs,
> Haochen
>
> gcc/ChangeLog:
>
> PR target/43618
> * config/i386/sse.md (extendv2sfv2df2): New define_expand.
> (sse2_cvtps2pd_load<mask_name>): Rename extendvsdfv2df2.
>
> gcc/testsuite/ChangeLog:
>
> PR target/43618
> * gcc.target/i386/pr43618-1.c: New test.
This patch could be as simple as:
diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index 8cd0f617bf3..c331445cb2d 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -9195,7 +9195,7 @@
(define_insn "extendv2sfv2df2"
[(set (match_operand:V2DF 0 "register_operand" "=v")
(float_extend:V2DF
- (match_operand:V2SF 1 "register_operand" "v")))]
+ (match_operand:V2SF 1 "nonimmediate_operand" "vm")))]
"TARGET_MMX_WITH_SSE"
"%vcvtps2pd\t{%1, %0|%0, %1}"
[(set_attr "type" "ssecvt")
Uros.
next prev parent reply other threads:[~2022-06-30 6:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 5:59 Haochen Jiang
2022-06-30 6:20 ` Uros Bizjak [this message]
2022-06-30 7:24 ` Jiang, Haochen
2022-06-30 7:41 ` Uros Bizjak
2022-06-30 8:45 ` Uros Bizjak
2022-06-30 8:53 ` Uros Bizjak
2022-06-30 8:57 ` Liu, Hongtao
2022-07-04 5:09 ` Jiang, Haochen
2022-07-04 6:17 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4aJ_a+zQh_L5eeAiBpiGAY8gcLuK9psQ6fXftc4k-TJig@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=haochen.jiang@intel.com \
--cc=hongtao.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).