From: Richard Biener <richard.guenther@gmail.com>
To: Zopolis0 <creatorsmithmdt@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.
Date: Mon, 28 Nov 2022 09:25:54 +0100 [thread overview]
Message-ID: <CAFiYyc0HgO-+Su1eB8pN_dT6T2Zg=TY458YOmhELbmK1MRSFLQ@mail.gmail.com> (raw)
In-Reply-To: <CAEYL+X9vPYwZ25V_irLi1rH_3rusU8cmyrc6pwZP-n2JrTLLww@mail.gmail.com>
On Sat, Nov 26, 2022 at 1:19 AM Zopolis0 <creatorsmithmdt@gmail.com> wrote:
>
> I was reverting a076632e274abe344ca7648b7c7f299273d4cbe0 as it removed code for Java, but I may have misunderstood the change and made the incorrect edits.
The change is fixing a bug (setting TREE_ADDRESSABLE from a CTOR in
debug stmts) and fixes up the C++ frontend to
properly mark things addressable when needed. I suspect the Java
frontend will need something similar - when
there's breakage without this reversion track down where what is
complained on is produced in the Java frontend
and properly mark things as TREE_ADDRESSABLE there.
Richard.
> On Sat, 26 Nov 2022 at 07:16, Richard Biener <richard.guenther@gmail.com> wrote:
>>
>> On Fri, Nov 25, 2022 at 9:43 AM Zopolis0 via Gcc-patches
>> <gcc-patches@gcc.gnu.org> wrote:
>> >
>>
>> That's wrong and the comment you remove explains why.
next prev parent reply other threads:[~2022-11-28 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 8:40 Zopolis0
2022-11-25 20:16 ` Richard Biener
2022-11-26 0:19 ` Zopolis0
2022-11-28 8:25 ` Richard Biener [this message]
2022-12-06 12:06 ` Zopolis0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0HgO-+Su1eB8pN_dT6T2Zg=TY458YOmhELbmK1MRSFLQ@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=creatorsmithmdt@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).