* [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.
@ 2022-11-25 8:40 Zopolis0
2022-11-25 20:16 ` Richard Biener
0 siblings, 1 reply; 5+ messages in thread
From: Zopolis0 @ 2022-11-25 8:40 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: 0014-middle-end-Set-TREE_ADDRESSABLE-in-folding-debug-stm.patch --]
[-- Type: application/x-patch, Size: 1607 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.
2022-11-25 8:40 [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts Zopolis0
@ 2022-11-25 20:16 ` Richard Biener
2022-11-26 0:19 ` Zopolis0
0 siblings, 1 reply; 5+ messages in thread
From: Richard Biener @ 2022-11-25 20:16 UTC (permalink / raw)
To: Zopolis0; +Cc: gcc-patches
On Fri, Nov 25, 2022 at 9:43 AM Zopolis0 via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
That's wrong and the comment you remove explains why.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.
2022-11-25 20:16 ` Richard Biener
@ 2022-11-26 0:19 ` Zopolis0
2022-11-28 8:25 ` Richard Biener
0 siblings, 1 reply; 5+ messages in thread
From: Zopolis0 @ 2022-11-26 0:19 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
I was reverting a076632e274abe344ca7648b7c7f299273d4cbe0 as it removed code
for Java, but I may have misunderstood the change and made the incorrect
edits.
On Sat, 26 Nov 2022 at 07:16, Richard Biener <richard.guenther@gmail.com>
wrote:
> On Fri, Nov 25, 2022 at 9:43 AM Zopolis0 via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
>
> That's wrong and the comment you remove explains why.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.
2022-11-26 0:19 ` Zopolis0
@ 2022-11-28 8:25 ` Richard Biener
2022-12-06 12:06 ` Zopolis0
0 siblings, 1 reply; 5+ messages in thread
From: Richard Biener @ 2022-11-28 8:25 UTC (permalink / raw)
To: Zopolis0; +Cc: gcc-patches
On Sat, Nov 26, 2022 at 1:19 AM Zopolis0 <creatorsmithmdt@gmail.com> wrote:
>
> I was reverting a076632e274abe344ca7648b7c7f299273d4cbe0 as it removed code for Java, but I may have misunderstood the change and made the incorrect edits.
The change is fixing a bug (setting TREE_ADDRESSABLE from a CTOR in
debug stmts) and fixes up the C++ frontend to
properly mark things addressable when needed. I suspect the Java
frontend will need something similar - when
there's breakage without this reversion track down where what is
complained on is produced in the Java frontend
and properly mark things as TREE_ADDRESSABLE there.
Richard.
> On Sat, 26 Nov 2022 at 07:16, Richard Biener <richard.guenther@gmail.com> wrote:
>>
>> On Fri, Nov 25, 2022 at 9:43 AM Zopolis0 via Gcc-patches
>> <gcc-patches@gcc.gnu.org> wrote:
>> >
>>
>> That's wrong and the comment you remove explains why.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.
2022-11-28 8:25 ` Richard Biener
@ 2022-12-06 12:06 ` Zopolis0
0 siblings, 0 replies; 5+ messages in thread
From: Zopolis0 @ 2022-12-06 12:06 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
New plan-- this patch is entirely pointless! I have reverted it in a
local build and had no regressions.
As such, simply do not review or consider this patch. I am not not
planning on re-sending the patchset even though it adjusts the patch
numbers because it is such an arduous process given that gmail no
longer supports git send-email.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-06 12:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 8:40 [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts Zopolis0
2022-11-25 20:16 ` Richard Biener
2022-11-26 0:19 ` Zopolis0
2022-11-28 8:25 ` Richard Biener
2022-12-06 12:06 ` Zopolis0
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).