* [PATCH] testsuite: XFAIL bogus g++.dg/warn/Wstringop-overflow-4.C:144, PR106120
@ 2023-02-07 16:50 Hans-Peter Nilsson
2023-02-07 16:52 ` Aldy Hernandez
0 siblings, 1 reply; 4+ messages in thread
From: Hans-Peter Nilsson @ 2023-02-07 16:50 UTC (permalink / raw)
To: gcc-patches; +Cc: aldyh
(sort-of-ping:) Aldy, I missed CC:ing you on the similar
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611206.html
would you mind having a look?
Tested native x86_64-pc-linux-gnu (w/wo. -m32) and cris-elf.
Ok to commit?
---- 8< ----
There was a commit r13-2082-gbf13a13c65bd06 "c++: remove some xfails"
(not referencing the PR) that dealt with part of the PR, but didn't
xfail the ilp32-specific (bogus) warning mentioned in the PR.
PR testsuite/106120
* g++.dg/warn/Wstringop-overflow-4.C:144 XFAIL bogus warning for
ilp32 targets with c++98.
---
gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
index 3716d2d13be0..35fb59e02320 100644
--- a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
+++ b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
@@ -141,7 +141,7 @@ void test_strcpy_new_int16_t (size_t n, const size_t vals[])
int r_imin_imax = SR (INT_MIN, INT_MAX);
T (S (1), new int16_t[r_imin_imax]);
- T (S (2), new int16_t[r_imin_imax + 1]);
+ T (S (2), new int16_t[r_imin_imax + 1]); // { dg-bogus "into a region of size" "pr106120" { xfail { ilp32 && c++98_only } } }
T (S (9), new int16_t[r_imin_imax * 2 + 1]);
int r_0_imax = SR (0, INT_MAX);
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] testsuite: XFAIL bogus g++.dg/warn/Wstringop-overflow-4.C:144, PR106120
2023-02-07 16:50 [PATCH] testsuite: XFAIL bogus g++.dg/warn/Wstringop-overflow-4.C:144, PR106120 Hans-Peter Nilsson
@ 2023-02-07 16:52 ` Aldy Hernandez
2023-02-07 18:03 ` Hans-Peter Nilsson
0 siblings, 1 reply; 4+ messages in thread
From: Aldy Hernandez @ 2023-02-07 16:52 UTC (permalink / raw)
To: Hans-Peter Nilsson, gcc-patches
Up to the release managers, but I have no objections.
Aldy
On 2/7/23 17:50, Hans-Peter Nilsson wrote:
> (sort-of-ping:) Aldy, I missed CC:ing you on the similar
> https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611206.html
> would you mind having a look?
>
> Tested native x86_64-pc-linux-gnu (w/wo. -m32) and cris-elf.
> Ok to commit?
>
> ---- 8< ----
> There was a commit r13-2082-gbf13a13c65bd06 "c++: remove some xfails"
> (not referencing the PR) that dealt with part of the PR, but didn't
> xfail the ilp32-specific (bogus) warning mentioned in the PR.
>
> PR testsuite/106120
> * g++.dg/warn/Wstringop-overflow-4.C:144 XFAIL bogus warning for
> ilp32 targets with c++98.
> ---
> gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
> index 3716d2d13be0..35fb59e02320 100644
> --- a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
> +++ b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
> @@ -141,7 +141,7 @@ void test_strcpy_new_int16_t (size_t n, const size_t vals[])
>
> int r_imin_imax = SR (INT_MIN, INT_MAX);
> T (S (1), new int16_t[r_imin_imax]);
> - T (S (2), new int16_t[r_imin_imax + 1]);
> + T (S (2), new int16_t[r_imin_imax + 1]); // { dg-bogus "into a region of size" "pr106120" { xfail { ilp32 && c++98_only } } }
> T (S (9), new int16_t[r_imin_imax * 2 + 1]);
>
> int r_0_imax = SR (0, INT_MAX);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] testsuite: XFAIL bogus g++.dg/warn/Wstringop-overflow-4.C:144, PR106120
2023-02-07 16:52 ` Aldy Hernandez
@ 2023-02-07 18:03 ` Hans-Peter Nilsson
2023-02-09 7:27 ` Richard Biener
0 siblings, 1 reply; 4+ messages in thread
From: Hans-Peter Nilsson @ 2023-02-07 18:03 UTC (permalink / raw)
To: Aldy Hernandez; +Cc: gcc-patches
> From: Aldy Hernandez <aldyh@redhat.com>
> Date: Tue, 7 Feb 2023 17:52:02 +0100
> Up to the release managers, but I have no objections.
I take it that's for both patches. Thanks!
(Potential reviewers: these patches are local to the testsuite.)
brgds, H-P
>
> Aldy
>
> On 2/7/23 17:50, Hans-Peter Nilsson wrote:
> > (sort-of-ping:) Aldy, I missed CC:ing you on the similar
> > https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611206.html
> > would you mind having a look?
> >
> > Tested native x86_64-pc-linux-gnu (w/wo. -m32) and cris-elf.
> > Ok to commit?
> >
> > ---- 8< ----
> > There was a commit r13-2082-gbf13a13c65bd06 "c++: remove some xfails"
> > (not referencing the PR) that dealt with part of the PR, but didn't
> > xfail the ilp32-specific (bogus) warning mentioned in the PR.
> >
> > PR testsuite/106120
> > * g++.dg/warn/Wstringop-overflow-4.C:144 XFAIL bogus warning for
> > ilp32 targets with c++98.
> > ---
> > gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
> > index 3716d2d13be0..35fb59e02320 100644
> > --- a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
> > +++ b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
> > @@ -141,7 +141,7 @@ void test_strcpy_new_int16_t (size_t n, const size_t vals[])
> >
> > int r_imin_imax = SR (INT_MIN, INT_MAX);
> > T (S (1), new int16_t[r_imin_imax]);
> > - T (S (2), new int16_t[r_imin_imax + 1]);
> > + T (S (2), new int16_t[r_imin_imax + 1]); // { dg-bogus "into a region of size" "pr106120" { xfail { ilp32 && c++98_only } } }
> > T (S (9), new int16_t[r_imin_imax * 2 + 1]);
> >
> > int r_0_imax = SR (0, INT_MAX);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] testsuite: XFAIL bogus g++.dg/warn/Wstringop-overflow-4.C:144, PR106120
2023-02-07 18:03 ` Hans-Peter Nilsson
@ 2023-02-09 7:27 ` Richard Biener
0 siblings, 0 replies; 4+ messages in thread
From: Richard Biener @ 2023-02-09 7:27 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: Aldy Hernandez, gcc-patches
On Tue, Feb 7, 2023 at 7:04 PM Hans-Peter Nilsson via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> > From: Aldy Hernandez <aldyh@redhat.com>
> > Date: Tue, 7 Feb 2023 17:52:02 +0100
>
> > Up to the release managers, but I have no objections.
>
> I take it that's for both patches. Thanks!
> (Potential reviewers: these patches are local to the testsuite.)
OK
> brgds, H-P
>
>
> >
> > Aldy
> >
> > On 2/7/23 17:50, Hans-Peter Nilsson wrote:
> > > (sort-of-ping:) Aldy, I missed CC:ing you on the similar
> > > https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611206.html
> > > would you mind having a look?
> > >
> > > Tested native x86_64-pc-linux-gnu (w/wo. -m32) and cris-elf.
> > > Ok to commit?
> > >
> > > ---- 8< ----
> > > There was a commit r13-2082-gbf13a13c65bd06 "c++: remove some xfails"
> > > (not referencing the PR) that dealt with part of the PR, but didn't
> > > xfail the ilp32-specific (bogus) warning mentioned in the PR.
> > >
> > > PR testsuite/106120
> > > * g++.dg/warn/Wstringop-overflow-4.C:144 XFAIL bogus warning for
> > > ilp32 targets with c++98.
> > > ---
> > > gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
> > > index 3716d2d13be0..35fb59e02320 100644
> > > --- a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
> > > +++ b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C
> > > @@ -141,7 +141,7 @@ void test_strcpy_new_int16_t (size_t n, const size_t vals[])
> > >
> > > int r_imin_imax = SR (INT_MIN, INT_MAX);
> > > T (S (1), new int16_t[r_imin_imax]);
> > > - T (S (2), new int16_t[r_imin_imax + 1]);
> > > + T (S (2), new int16_t[r_imin_imax + 1]); // { dg-bogus "into a region of size" "pr106120" { xfail { ilp32 && c++98_only } } }
> > > T (S (9), new int16_t[r_imin_imax * 2 + 1]);
> > >
> > > int r_0_imax = SR (0, INT_MAX);
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-09 7:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 16:50 [PATCH] testsuite: XFAIL bogus g++.dg/warn/Wstringop-overflow-4.C:144, PR106120 Hans-Peter Nilsson
2023-02-07 16:52 ` Aldy Hernandez
2023-02-07 18:03 ` Hans-Peter Nilsson
2023-02-09 7:27 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).