public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: HAO CHEN GUI <guihaoc@linux.ibm.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	 Peter Bergner <bergner@linux.ibm.com>,
	Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions
Date: Thu, 25 Aug 2022 10:01:38 -0400	[thread overview]
Message-ID: <CAGWvnynV04eiyMcPgN7vD19WGzi6FJ8eVVnLu32=6xcyDTi60A@mail.gmail.com> (raw)
In-Reply-To: <8177d3a3-ec97-c15e-dddd-ec88930757dd@linux.ibm.com>

On Thu, Aug 25, 2022 at 1:22 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> on 2022/8/25 11:37, HAO CHEN GUI wrote:
> > Hi,
> >
> > On 24/8/2022 下午 1:24, Kewen.Lin wrote:
> >> Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" all the time, but still
> >> having that has_arch_ppc64 effective target on aix?
> >>
> >> I'd expect has_arch_ppc64 check to fail on aix 32bit, the error will not be a problem (turning
> >> into an UNSUPPORTED then)?
> >
> > I tested it on AIX. "has_arch_ppc64" fails with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" on
> > 32-bit AIX environment. It works as we expected.
>
> Nice, thanks for your time on testing.
>
> >
> > Also I found that AIX and Darwin are skipped for bfp test. So in testcase, it's no need to care
> > about them. Not sure if it's intention.
> >
> > In bfp.exp
> >
> > # Exit immediately if this isn't a PowerPC target or if the target is
> > # aix or Darwin.
> > if { (![istarget powerpc*-*-*] && ![istarget rs6000-*-*])
> >      || [istarget "powerpc*-*-aix*"]
> >      || [istarget "powerpc*-*-darwin*"]  } then {
> >   return
> > }
>
> I can't find a hint about why we wanted to disable bfp testing on aix, it looks like a overkill to me.
>
> Could you help to further test if all test cases in this small bucket available on aix?
>
> Maybe it can give us some evidences on why it's intentional or not.
>
> Hi David & Segher,
>
> Do you have some insights on this?

AIX (and Darwin) are not Linux and not ELF.  There is no support for
BPF.  All of the tests fail, so they are skipped.

Thanks, David

  reply	other threads:[~2022-08-25 14:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  2:35 HAO CHEN GUI
2022-08-19  3:01 ` Kewen.Lin
2022-08-19  6:09   ` HAO CHEN GUI
2022-08-23 14:26 ` Segher Boessenkool
2022-08-24  5:11   ` HAO CHEN GUI
2022-08-24  5:24     ` Kewen.Lin
2022-08-24  6:31       ` HAO CHEN GUI
2022-08-25  3:37       ` HAO CHEN GUI
2022-08-25  5:22         ` Kewen.Lin
2022-08-25 14:01           ` David Edelsohn [this message]
2022-08-26  2:42             ` HAO CHEN GUI
2022-08-26  2:51               ` Kewen.Lin
2022-08-26 13:32               ` David Edelsohn
2022-08-25 15:17     ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGWvnynV04eiyMcPgN7vD19WGzi6FJ8eVVnLu32=6xcyDTi60A@mail.gmail.com' \
    --to=dje.gcc@gmail.com \
    --cc=bergner@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=guihaoc@linux.ibm.com \
    --cc=linkw@linux.ibm.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).