Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

["Kewen.Lin" <linkw@linux.ibm.com>]

on 2022/8/26 10:42, HAO CHEN GUI wrote:
> Hi David,
> 
> On 25/8/2022 下午 10:01, David Edelsohn wrote:
>> On Thu, Aug 25, 2022 at 1:22 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>>>
>>> on 2022/8/25 11:37, HAO CHEN GUI wrote:
>>>> Hi,
>>>>
>>>> On 24/8/2022 下午 1:24, Kewen.Lin wrote:
>>>>> Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" all the time, but still
>>>>> having that has_arch_ppc64 effective target on aix?
>>>>>
>>>>> I'd expect has_arch_ppc64 check to fail on aix 32bit, the error will not be a problem (turning
>>>>> into an UNSUPPORTED then)?
>>>>
>>>> I tested it on AIX. "has_arch_ppc64" fails with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" on
>>>> 32-bit AIX environment. It works as we expected.
>>>
>>> Nice, thanks for your time on testing.
>>>
>>>>
>>>> Also I found that AIX and Darwin are skipped for bfp test. So in testcase, it's no need to care
>>>> about them. Not sure if it's intention.
>>>>
>>>> In bfp.exp
>>>>
>>>> # Exit immediately if this isn't a PowerPC target or if the target is
>>>> # aix or Darwin.
>>>> if { (![istarget powerpc*-*-*] && ![istarget rs6000-*-*])
>>>>      || [istarget "powerpc*-*-aix*"]
>>>>      || [istarget "powerpc*-*-darwin*"]  } then {
>>>>   return
>>>> }
>>>
>>> I can't find a hint about why we wanted to disable bfp testing on aix, it looks like a overkill to me.
>>>
>>> Could you help to further test if all test cases in this small bucket available on aix?
>>>
>>> Maybe it can give us some evidences on why it's intentional or not.
>>>
>>> Hi David & Segher,
>>>
>>> Do you have some insights on this?
>>
>> AIX (and Darwin) are not Linux and not ELF.  There is no support for
>> BPF.  All of the tests fail, so they are skipped.
> 
> Thanks so much for your info.

+1!

But I guessed the name BFP (short for IEEE binary fp IMHO) was misread as BPF (eBPF)? 

> 
> Here are test results on P7 AIX7.1. I tested all scalar-extract-sig-* and scalar-insert-exp-* cases in
> "testsuite/powerpc/bfp" fold. All compiling cases pass except those use __ieee128. The runnable cases
> fail as expected. p9vector is not supported on P7 servers.

Thanks for testing again.

> 
> So the __ieee128 blocks Binary floating-point on AIX?

We can add one extra effective target ppc_ieee128_ok for them, aix is already excluded in the check.

BR,
Kewen