[PATCH][pushed] remove dead member variable in dom_jt_state

[PATCH][pushed] remove dead member variable in dom_jt_state

[Martin Liška]

Hi.

I'm going to push the following clean-up.

Martin

gcc/ChangeLog:

	* tree-ssa-dom.cc (pass_dominator::execute): Remove m_ranger as
	it is unused.
---
 gcc/tree-ssa-dom.cc | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/gcc/tree-ssa-dom.cc b/gcc/tree-ssa-dom.cc
index dcaf4672b66..9b6520fd2dd 100644
--- a/gcc/tree-ssa-dom.cc
+++ b/gcc/tree-ssa-dom.cc
@@ -588,9 +588,8 @@ record_edge_info (basic_block bb)
 class dom_jt_state : public jt_state
 {
 public:
-  dom_jt_state (const_and_copies *copies, avail_exprs_stack *avails,
-		gimple_ranger *ranger)
-    : m_copies (copies), m_avails (avails), m_ranger (ranger)
+  dom_jt_state (const_and_copies *copies, avail_exprs_stack *avails)
+    : m_copies (copies), m_avails (avails)
   {
   }
   void push (edge e) override
@@ -613,7 +612,6 @@ public:
 private:
   const_and_copies *m_copies;
   avail_exprs_stack *m_avails;
-  gimple_ranger *m_ranger;
 };
 
 void
@@ -794,7 +792,7 @@ pass_dominator::execute (function *fun)
   gimple_ranger *ranger = enable_ranger (fun);
   path_range_query path_query (/*resolve=*/true, ranger);
   dom_jt_simplifier simplifier (avail_exprs_stack, ranger, &path_query);
-  dom_jt_state state (const_and_copies, avail_exprs_stack, ranger);
+  dom_jt_state state (const_and_copies, avail_exprs_stack);
   jump_threader threader (&simplifier, &state);
   dom_opt_dom_walker walker (CDI_DOMINATORS,
 			     &threader,
-- 
2.36.1

Re: [PATCH][pushed] remove dead member variable in dom_jt_state

[Aldy Hernandez]

Anything dealing with the hybrid threader could probably use a little
clean up.  I've neglected to do so, as I'm hoping to nuke the forward
threader altogether and replace it with the backwards threader.
However, in order to do this, we need to implement prange (pointers)
and frange (floats) to handle the slack currently being picked up by
DOM.

Anywhoo...thanks for doing this.
Aldy

On Thu, Jun 30, 2022 at 10:29 AM Martin Liška <mliska@suse.cz> wrote:
>
> Hi.
>
> I'm going to push the following clean-up.
>
> Martin
>
> gcc/ChangeLog:
>
>         * tree-ssa-dom.cc (pass_dominator::execute): Remove m_ranger as
>         it is unused.
> ---
>  gcc/tree-ssa-dom.cc | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/gcc/tree-ssa-dom.cc b/gcc/tree-ssa-dom.cc
> index dcaf4672b66..9b6520fd2dd 100644
> --- a/gcc/tree-ssa-dom.cc
> +++ b/gcc/tree-ssa-dom.cc
> @@ -588,9 +588,8 @@ record_edge_info (basic_block bb)
>  class dom_jt_state : public jt_state
>  {
>  public:
> -  dom_jt_state (const_and_copies *copies, avail_exprs_stack *avails,
> -               gimple_ranger *ranger)
> -    : m_copies (copies), m_avails (avails), m_ranger (ranger)
> +  dom_jt_state (const_and_copies *copies, avail_exprs_stack *avails)
> +    : m_copies (copies), m_avails (avails)
>    {
>    }
>    void push (edge e) override
> @@ -613,7 +612,6 @@ public:
>  private:
>    const_and_copies *m_copies;
>    avail_exprs_stack *m_avails;
> -  gimple_ranger *m_ranger;
>  };
>
>  void
> @@ -794,7 +792,7 @@ pass_dominator::execute (function *fun)
>    gimple_ranger *ranger = enable_ranger (fun);
>    path_range_query path_query (/*resolve=*/true, ranger);
>    dom_jt_simplifier simplifier (avail_exprs_stack, ranger, &path_query);
> -  dom_jt_state state (const_and_copies, avail_exprs_stack, ranger);
> +  dom_jt_state state (const_and_copies, avail_exprs_stack);
>    jump_threader threader (&simplifier, &state);
>    dom_opt_dom_walker walker (CDI_DOMINATORS,
>                              &threader,
> --
> 2.36.1
>